test: cover DataFrame feature names in MovesManagementClassifier - #146
Merged
shivamlalakiya merged 6 commits intoAug 24, 2026
Merged
Conversation
The changelog line landed as a sub-bullet of the CRMCleaner entry under ### Fixed; test coverage is an addition, so move it to ### Added at top level. The CONTRIBUTORS line was indented two spaces, rendering as a child of the entry above it.
…e-names # Conflicts: # CONTRIBUTORS.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Adds regression coverage for
MovesManagementClassifier.fitwhen the feature matrix is provided as apandas.DataFrame.The new test verifies that fitting on named DataFrame columns correctly preserves those names in
feature_names_in_.Closes #54.
Local CI completed successfully:
Result:
Checklist
make cipasses locally (lint → collection → tests → coverage ≥ 92%)__init__.pyCHANGELOG.mdupdated under[Unreleased]CONTRIBUTORS.md(skip if you would rather not be listed)