Skip to content

test: RFMTransformer.fit never exercises the ndarray (non-Da - #139

Merged
shivamlalakiya merged 3 commits into
PhilanthroPy-Project:mainfrom
Mr-Neutr0n:agent/issue-49-test-rfmtransformerfit
Aug 24, 2026
Merged

test: RFMTransformer.fit never exercises the ndarray (non-Da#139
shivamlalakiya merged 3 commits into
PhilanthroPy-Project:mainfrom
Mr-Neutr0n:agent/issue-49-test-rfmtransformerfit

Conversation

@Mr-Neutr0n

Copy link
Copy Markdown
Contributor

Fixes #49

Added test_rfm_transformer_ndarray_input_raises_missing_columns to cover RFMTransformer.fit’s bare-ndarray path and verify it raises ValueError for missing required columns.

Local tests pass.


This change was prepared with AI assistance under human direction and review.

… the ndarray (non-Da

Signed-off-by: Mr-Neutr0n <64578610+Mr-Neutr0n@users.noreply.github.com>
@shivamlalakiya

Copy link
Copy Markdown
Contributor

Test looks correct and covers the missing-columns ndarray path cleanly. Per AGENTS.md, every PR needs a CHANGELOG.md entry under ## [Unreleased], and since this lands your first contribution, a one-line add-yourself in CONTRIBUTORS.md too (see the 'Getting listed' section there). Could you add both? Holding the merge until then.

@shivamlalakiya

Copy link
Copy Markdown
Contributor

The test itself is good: six lines, closes the real gap in issue #49, and it pins the donor_id message rather than a bare ValueError, so a regression that swaps the error text still fails the test.

Blocking on one repo rule, not on the code: AGENTS.md requires every PR to add its author to CONTRIBUTORS.md in the same PR, and @Mr-Neutr0n is not listed there yet. Please add yourself (see the "Getting listed" section) and I will merge.

No CHANGELOG entry needed here -- test-only PRs (#107, #118) have merged without one, and PR #128 is adding a CI guard that scopes the changelog requirement to changes under philanthropy/.

@Mr-Neutr0n

Copy link
Copy Markdown
Contributor Author

Added myself to CONTRIBUTORS.md per the AGENTS.md rule: fc14ccc. Ready for merge.

@shivamlalakiya
shivamlalakiya merged commit 14dad38 into PhilanthroPy-Project:main Aug 24, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: RFMTransformer.fit never exercises the ndarray (non-DataFrame) input branch

2 participants