Fix SQL column names with spaces and reserved keywords#86
Merged
Conversation
Changed GetColumnName to GetQuotedColumnName in SqlDialectBuilder.GetUpdates() to properly quote column names in UPDATE SET clauses. Added test entity TestEntityWithSpecialColumnNames with columns like "Business Function Text" and "Order Number" to verify the fix. Added test cases for both basic insert and merge operations with special column names. Co-authored-by: PhenX <42170+PhenX@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix SQL column names with spaces and keywords issue
Fix SQL column names with spaces and reserved keywords
Dec 21, 2025
Owner
|
@copilot ignore the insert+merge+return test on oracle as it does not support it |
Oracle does not support insert+merge+return operations. Co-authored-by: PhenX <42170+PhenX@users.noreply.github.com>
Contributor
Author
PhenX
approved these changes
Dec 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetUpdates()method inSqlDialectBuilder.csuses unquoted column namesGetUpdates()inSqlDialectBuilder.csto useGetQuotedColumnName()instead ofGetColumnName()Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.