Skip to content

Handle SmartEnum properties#76

Merged
PhenX merged 3 commits intomainfrom
bugfix/issue-74
Oct 15, 2025
Merged

Handle SmartEnum properties#76
PhenX merged 3 commits intomainfrom
bugfix/issue-74

Conversation

@PhenX
Copy link
Copy Markdown
Owner

@PhenX PhenX commented Oct 15, 2025

No description provided.

@PhenX PhenX requested a review from Copilot October 15, 2025 20:35
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for SmartEnum properties in Entity Framework Core bulk insert operations. The changes include adding the necessary infrastructure to handle SmartEnum type conversions during bulk operations, along with comprehensive test coverage across all supported database providers.

Key Changes:

  • Added support for SmartEnum properties via the Ardalis.SmartEnum.EFCore package
  • Fixed a null-check condition in PropertyAccessor to properly handle value type converter outputs
  • Added comprehensive test coverage for SmartEnum entities across all database providers
  • Updated various package dependencies to their latest versions

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/PhenX.EntityFrameworkCore.BulkInsert/Metadata/PropertyAccessor.cs Fixed null-check logic to account for value type converter outputs
tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/DbContext/TestSmartEnum.cs Added test SmartEnum implementation
tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/DbContext/TestEntityWithSmartEnum.cs Added test entity with SmartEnum property
tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/DbContext/TestDbContext.cs Configured SmartEnum support in test context
tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/Tests/Various/VariousTestsBase.cs Added base test class for SmartEnum insertion tests
tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/Tests/Various/VariousTestsSqlite.cs Added SQLite-specific test implementation
tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/Tests/Various/VariousTestsSqlServer.cs Added SQL Server-specific test implementation
tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/Tests/Various/VariousTestsPostgreSql.cs Added PostgreSQL-specific test implementation
tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/Tests/Various/VariousTestsOracle.cs Added Oracle-specific test implementation
tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/Tests/Various/VariousTestsMySql.cs Added MySQL-specific test implementation
tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/PhenX.EntityFrameworkCore.BulkInsert.Tests.csproj Added SmartEnum package and updated test dependencies
tests/PhenX.EntityFrameworkCore.BulkInsert.Benchmark/PhenX.EntityFrameworkCore.BulkInsert.Benchmark.csproj Updated benchmark dependencies
src/PhenX.EntityFrameworkCore.BulkInsert.Oracle/PhenX.EntityFrameworkCore.BulkInsert.Oracle.csproj Updated Oracle EF Core package versions
src/PhenX.EntityFrameworkCore.BulkInsert.MySql/PhenX.EntityFrameworkCore.BulkInsert.MySql.csproj Updated MySQL EF Core package to stable release
src/Directory.Build.props Updated JetBrains.Annotations package version

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

# Conflicts:
#	tests/PhenX.EntityFrameworkCore.BulkInsert.Benchmark/PhenX.EntityFrameworkCore.BulkInsert.Benchmark.csproj
#	tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/PhenX.EntityFrameworkCore.BulkInsert.Tests.csproj
@PhenX PhenX merged commit df214d8 into main Oct 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants