Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for SmartEnum properties in Entity Framework Core bulk insert operations. The changes include adding the necessary infrastructure to handle SmartEnum type conversions during bulk operations, along with comprehensive test coverage across all supported database providers.
Key Changes:
- Added support for SmartEnum properties via the Ardalis.SmartEnum.EFCore package
- Fixed a null-check condition in PropertyAccessor to properly handle value type converter outputs
- Added comprehensive test coverage for SmartEnum entities across all database providers
- Updated various package dependencies to their latest versions
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/PhenX.EntityFrameworkCore.BulkInsert/Metadata/PropertyAccessor.cs | Fixed null-check logic to account for value type converter outputs |
| tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/DbContext/TestSmartEnum.cs | Added test SmartEnum implementation |
| tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/DbContext/TestEntityWithSmartEnum.cs | Added test entity with SmartEnum property |
| tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/DbContext/TestDbContext.cs | Configured SmartEnum support in test context |
| tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/Tests/Various/VariousTestsBase.cs | Added base test class for SmartEnum insertion tests |
| tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/Tests/Various/VariousTestsSqlite.cs | Added SQLite-specific test implementation |
| tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/Tests/Various/VariousTestsSqlServer.cs | Added SQL Server-specific test implementation |
| tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/Tests/Various/VariousTestsPostgreSql.cs | Added PostgreSQL-specific test implementation |
| tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/Tests/Various/VariousTestsOracle.cs | Added Oracle-specific test implementation |
| tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/Tests/Various/VariousTestsMySql.cs | Added MySQL-specific test implementation |
| tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/PhenX.EntityFrameworkCore.BulkInsert.Tests.csproj | Added SmartEnum package and updated test dependencies |
| tests/PhenX.EntityFrameworkCore.BulkInsert.Benchmark/PhenX.EntityFrameworkCore.BulkInsert.Benchmark.csproj | Updated benchmark dependencies |
| src/PhenX.EntityFrameworkCore.BulkInsert.Oracle/PhenX.EntityFrameworkCore.BulkInsert.Oracle.csproj | Updated Oracle EF Core package versions |
| src/PhenX.EntityFrameworkCore.BulkInsert.MySql/PhenX.EntityFrameworkCore.BulkInsert.MySql.csproj | Updated MySQL EF Core package to stable release |
| src/Directory.Build.props | Updated JetBrains.Annotations package version |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
# Conflicts: # tests/PhenX.EntityFrameworkCore.BulkInsert.Benchmark/PhenX.EntityFrameworkCore.BulkInsert.Benchmark.csproj # tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/PhenX.EntityFrameworkCore.BulkInsert.Tests.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.