Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates dependencies across test and source projects to newer versions for compatibility with .NET 8/9 and to keep third-party libraries current.
- Bump Testcontainers to 4.7.0 in tests; update xUnit runner and Microsoft.NET.Test.Sdk.
- Update EF Core-related providers and BulkExtensions, including Pomelo and Oracle packages.
- Refresh shared tooling and annotations (BenchmarkDotNet, JetBrains.Annotations).
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/PhenX.EntityFrameworkCore.BulkInsert.Tests.csproj | Updates Testcontainers to 4.7.0 and test tooling versions; aligns EF NetTopologySuite provider versions. |
| tests/PhenX.EntityFrameworkCore.BulkInsert.Benchmark/PhenX.EntityFrameworkCore.BulkInsert.Benchmark.csproj | Updates BenchmarkDotNet and bulk operation packages; retains older Testcontainers versions (potential mismatch). |
| src/PhenX.EntityFrameworkCore.BulkInsert.Oracle/PhenX.EntityFrameworkCore.BulkInsert.Oracle.csproj | Upgrades Oracle.EntityFrameworkCore to latest patch versions for net8/net9. |
| src/PhenX.EntityFrameworkCore.BulkInsert.MySql/PhenX.EntityFrameworkCore.BulkInsert.MySql.csproj | Changes Pomelo net9.0 reference to a floating 9.0.* version. |
| src/Directory.Build.props | Updates JetBrains.Annotations to 2025.2.2. |
Comments suppressed due to low confidence (1)
tests/PhenX.EntityFrameworkCore.BulkInsert.Benchmark/PhenX.EntityFrameworkCore.BulkInsert.Benchmark.csproj:14
- [nitpick] The tests project was upgraded to Testcontainers 4.7.0, but the benchmark project still references 4.4.0. To avoid version drift and potential restore/runtime inconsistencies, align these to 4.7.0 (or centralize via Directory.Packages.props) in this project as well.
<PackageReference Include="Testcontainers.PostgreSql" Version="4.4.0" />
<PackageReference Include="Testcontainers.MsSql" Version="4.4.0" />
<PackageReference Include="Testcontainers.MySql" Version="4.4.0" />
<PackageReference Include="Testcontainers.Oracle" Version="4.4.0" />
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.