Add oracle support #52
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| using Oracle.ManagedDataAccess.Client; | ||
|
|
||
| using PhenX.EntityFrameworkCore.BulkInsert.Options; | ||
|
|
||
| namespace PhenX.EntityFrameworkCore.BulkInsert.Oracle; | ||
|
|
||
| /// <summary> | ||
| /// Options specific to Oracle bulk insert. | ||
| /// </summary> | ||
| public class OracleBulkInsertOptions : BulkInsertOptions | ||
| { | ||
| /// <inheritdoc cref="OracleBulkCopyOptions"/> | ||
| public OracleBulkCopyOptions CopyOptions { get; set; } = OracleBulkCopyOptions.Default; | ||
|
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| using JetBrains.Annotations; | ||
|
|
||
| using Microsoft.EntityFrameworkCore; | ||
| using Microsoft.Extensions.Logging; | ||
|
|
||
| using Oracle.ManagedDataAccess.Client; | ||
|
|
||
| using PhenX.EntityFrameworkCore.BulkInsert.Metadata; | ||
| using PhenX.EntityFrameworkCore.BulkInsert.Options; | ||
|
|
||
| namespace PhenX.EntityFrameworkCore.BulkInsert.Oracle; | ||
|
|
||
| [UsedImplicitly] | ||
| internal class OracleBulkInsertProvider(ILogger<OracleBulkInsertProvider>? logger) : BulkInsertProviderBase<OracleDialectBuilder, OracleBulkInsertOptions>(logger) | ||
| { | ||
| /// <inheritdoc /> | ||
| protected override string BulkInsertId => "ROWID"; | ||
|
|
||
| /// <inheritdoc /> | ||
| protected override string AddTableCopyBulkInsertId => ""; // No need to add an ID column in Oracle | ||
|
|
||
| /// <inheritdoc /> | ||
| protected override string GetTempTableName(string tableName) => $"#temp_bulk_insert_{Guid.NewGuid().ToString("N")[..8]}"; | ||
|
Collaborator
There was a problem hiding this comment. Why do you not take the whole guid?
Owner
Author
There was a problem hiding this comment. oracle under a certain version (12 I think) does not allow indentifiers longer than 30, yay
Collaborator
There was a problem hiding this comment. I would probably comment that, because I would have forgotten that next week.
Owner
Author
There was a problem hiding this comment. oh I will remember 😅 but yeah I'll add a comment
Collaborator
There was a problem hiding this comment. I ahve said this very often to myself :D |
||
|
|
||
| protected override OracleBulkInsertOptions CreateDefaultOptions() => new() | ||
| { | ||
| BatchSize = 50_000, | ||
| }; | ||
|
|
||
| /// <inheritdoc /> | ||
| protected override IAsyncEnumerable<T> BulkInsertReturnEntities<T>( | ||
| bool sync, | ||
| DbContext context, | ||
| TableMetadata tableInfo, | ||
| IEnumerable<T> entities, | ||
| OracleBulkInsertOptions options, | ||
| OnConflictOptions<T>? onConflict, | ||
| CancellationToken ctk) | ||
| { | ||
| throw new NotSupportedException("Provider does not support returning entities."); | ||
| } | ||
|
|
||
| /// <inheritdoc /> | ||
| protected override Task BulkInsert<T>( | ||
| bool sync, | ||
| DbContext context, | ||
| TableMetadata tableInfo, | ||
| IEnumerable<T> entities, | ||
| string tableName, | ||
| IReadOnlyList<ColumnMetadata> columns, | ||
| OracleBulkInsertOptions options, | ||
| CancellationToken ctk) | ||
| { | ||
| var connection = (OracleConnection) context.Database.GetDbConnection(); | ||
|
|
||
| using var bulkCopy = new OracleBulkCopy(connection, options.CopyOptions); | ||
|
|
||
| bulkCopy.DestinationTableName = tableInfo.QuotedTableName; | ||
| bulkCopy.BatchSize = options.BatchSize; | ||
| bulkCopy.BulkCopyTimeout = options.GetCopyTimeoutInSeconds(); | ||
|
|
||
| foreach (var column in columns) | ||
| { | ||
| bulkCopy.ColumnMappings.Add(column.PropertyName, column.QuotedColumName); | ||
| } | ||
|
|
||
| var dataReader = new EnumerableDataReader<T>(entities, columns, options); | ||
|
|
||
| bulkCopy.WriteToServer(dataReader); | ||
|
|
||
| return Task.CompletedTask; | ||
| } | ||
|
|
||
| /// <inheritdoc /> | ||
| protected override async Task DropTempTableAsync(bool sync, DbContext dbContext, string tableName) | ||
| { | ||
| var commandText = $""" | ||
| BEGIN | ||
| EXECUTE IMMEDIATE 'DROP TABLE {tableName}'; | ||
| EXCEPTION | ||
| WHEN OTHERS THEN | ||
| IF SQLCODE != -942 THEN -- ORA-00942: table or view does not exist | ||
| RAISE; | ||
| END IF; | ||
| END; | ||
| """; | ||
|
|
||
| await ExecuteAsync(sync, dbContext, commandText, CancellationToken.None); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| using Microsoft.EntityFrameworkCore; | ||
|
|
||
| using PhenX.EntityFrameworkCore.BulkInsert.Extensions; | ||
|
|
||
| namespace PhenX.EntityFrameworkCore.BulkInsert.Oracle; | ||
|
|
||
| /// <summary> | ||
| /// DbContext options extension for Oracle. | ||
| /// </summary> | ||
| public static class OracleDbContextOptionsExtensions | ||
| { | ||
| /// <summary> | ||
| /// Configures the DbContext to use the Oracle bulk insert provider. | ||
| /// </summary> | ||
| public static DbContextOptionsBuilder UseBulkInsertOracle(this DbContextOptionsBuilder optionsBuilder) | ||
| { | ||
| return optionsBuilder.UseProvider<OracleBulkInsertProvider>(); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,136 @@ | ||
| using System.Text; | ||
|
|
||
| using Microsoft.EntityFrameworkCore; | ||
|
|
||
| using PhenX.EntityFrameworkCore.BulkInsert.Dialect; | ||
| using PhenX.EntityFrameworkCore.BulkInsert.Metadata; | ||
| using PhenX.EntityFrameworkCore.BulkInsert.Options; | ||
|
|
||
| namespace PhenX.EntityFrameworkCore.BulkInsert.Oracle; | ||
|
|
||
| internal class OracleDialectBuilder : SqlDialectBuilder | ||
| { | ||
| protected override string OpenDelimiter => "\""; | ||
| protected override string CloseDelimiter => "\""; | ||
| protected override string ConcatOperator => "||"; | ||
|
|
||
| protected override bool SupportsMoveRows => false; | ||
|
|
||
| public override string CreateTableCopySql(string tempTableName, TableMetadata tableInfo, IReadOnlyList<ColumnMetadata> columns) | ||
| { | ||
| var q = new StringBuilder(); | ||
| q.Append($"CREATE TABLE {tempTableName} ("); | ||
|
|
||
| foreach (var column in columns) | ||
| { | ||
| q.Append($"{column.QuotedColumName} {column.StoreDefinition}"); | ||
|
Collaborator
There was a problem hiding this comment. I think I have made an extension method for this case AppenJoined(",\n", column, (c, sb) => sb.Append("...")); or something like that |
||
| if (column != columns[^1]) | ||
| { | ||
| q.Append(','); | ||
| } | ||
| q.AppendLine(); | ||
| } | ||
|
|
||
| q.AppendLine(")"); | ||
|
|
||
| return q.ToString(); | ||
| } | ||
|
|
||
| public override string BuildMoveDataSql<T>( | ||
| DbContext context, | ||
| TableMetadata target, | ||
| string source, | ||
| IReadOnlyList<ColumnMetadata> insertedColumns, | ||
| IReadOnlyList<ColumnMetadata> returnedColumns, | ||
| BulkInsertOptions options, | ||
| OnConflictOptions? onConflict = null) | ||
| { | ||
| var q = new StringBuilder(); | ||
|
|
||
| // Merge handling | ||
| if (onConflict is OnConflictOptions<T> onConflictTyped) | ||
| { | ||
| IEnumerable<string> matchColumns; | ||
| if (onConflictTyped.Match != null) | ||
| { | ||
| matchColumns = GetColumns(target, onConflictTyped.Match); | ||
| } | ||
| else if (target.PrimaryKey.Count > 0) | ||
| { | ||
| matchColumns = target.PrimaryKey.Select(x => x.QuotedColumName); | ||
| } | ||
| else | ||
| { | ||
| throw new InvalidOperationException("Table has no primary key that can be used for conflict detection."); | ||
| } | ||
|
|
||
| q.AppendLine($"MERGE INTO {target.QuotedTableName} AS TARGET"); | ||
|
|
||
| q.Append("USING (SELECT "); | ||
| q.AppendColumns(insertedColumns); | ||
| q.Append($" FROM {source}) AS SOURCE ("); | ||
| q.AppendColumns(insertedColumns); | ||
| q.AppendLine(")"); | ||
|
|
||
| q.Append("ON "); | ||
| q.AppendJoin(" AND ", matchColumns, (b, col) => b.Append($"TARGET.{col} = SOURCE.{col}")); | ||
| q.AppendLine(); | ||
|
|
||
| if (onConflictTyped.Update != null) | ||
| { | ||
| var columns = target.GetColumns(false); | ||
|
|
||
| q.AppendLine("WHEN MATCHED THEN UPDATE SET "); | ||
| q.AppendJoin(", ", GetUpdates(context, target, columns, onConflictTyped.Update)); | ||
| q.AppendLine(); | ||
| } | ||
|
|
||
| q.Append("WHEN NOT MATCHED THEN INSERT ("); | ||
| q.AppendColumns(insertedColumns); | ||
| q.AppendLine(")"); | ||
|
|
||
| q.Append("VALUES ("); | ||
| q.AppendJoin(", ", insertedColumns, (b, col) => b.Append($"SOURCE.{col.QuotedColumName}")); | ||
| q.AppendLine(")"); | ||
|
|
||
| if (returnedColumns.Count != 0) | ||
| { | ||
| q.Append("OUTPUT "); | ||
| q.AppendJoin(", ", returnedColumns, (b, col) => b.Append($"INSERTED.{col.QuotedColumName} AS {col.QuotedColumName}")); | ||
| q.AppendLine(); | ||
| } | ||
| } | ||
|
|
||
| // No conflict handling | ||
|
Collaborator
There was a problem hiding this comment. Perhaps two methods so that the comments are not necessary? |
||
| else | ||
| { | ||
| q.Append($"INSERT INTO {target.QuotedTableName} ("); | ||
| q.AppendColumns(insertedColumns); | ||
| q.AppendLine(")"); | ||
| q.Append("SELECT "); | ||
| q.AppendColumns(insertedColumns); | ||
| q.AppendLine(); | ||
| q.Append($"FROM {source}"); | ||
| q.AppendLine(); | ||
|
|
||
| if (returnedColumns.Count != 0) | ||
| { | ||
| q.Append("RETURNING "); | ||
| q.AppendJoin(", ", returnedColumns, (b, col) => b.Append(col.QuotedColumName)); | ||
| q.Append(" INTO "); | ||
| q.AppendJoin(", ", returnedColumns, (b, col) => b.Append($":{col.ColumnName}")); | ||
| q.AppendLine(); | ||
| } | ||
| } | ||
|
|
||
| q.AppendLine(";"); | ||
|
|
||
| var result = q.ToString(); | ||
|
Collaborator
There was a problem hiding this comment. Have you not got rid of this syntax in another PR aka return q.ToString(); |
||
| return result; | ||
| } | ||
|
|
||
| protected override string GetExcludedColumnName(string columnName) | ||
| { | ||
| return $"SOURCE.{columnName}"; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <ItemGroup> | ||
| <ProjectReference Include="..\PhenX.EntityFrameworkCore.BulkInsert\PhenX.EntityFrameworkCore.BulkInsert.csproj" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Oracle.EntityFrameworkCore" Condition="'$(TargetFramework)' == 'net8.0'" Version="8.23.80" /> | ||
| <PackageReference Include="Oracle.EntityFrameworkCore" Condition="'$(TargetFramework)' == 'net9.0'" Version="9.23.80" /> | ||
| </ItemGroup> | ||
|
|
||
| </Project> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Empty line