Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR splits existing merge tests into provider-specific files and performs cleanup in the basic tests base class.
- Adds separate
MergeTestsclasses for Sqlite, SqlServer, PostgreSql, and MySql, each inheriting from the shared base. - Cleans up
BasicTestsBase.cs: removes unused using, simplifies exclusion lambdas, deletes commented-out duplicate tests, and adjusts the test workload size. - Updates the many-entity insert test count and refactors some lambda parameter names.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/.../Merge/MergeTestsSqlite.cs | New Sqlite-specific merge tests subclass |
| tests/.../Merge/MergeTestsSqlServer.cs | New SqlServer-specific merge tests subclass |
| tests/.../Merge/MergeTestsPostgreSql.cs | New PostgreSql-specific merge tests subclass |
| tests/.../Merge/MergeTestsMySql.cs | New MySql-specific merge tests subclass |
| tests/.../Merge/MergeTestsBase.cs | Introduces shared merge tests logic in a generic base |
| tests/.../Basic/BasicTestsBase.cs | Removes unused import, simplifies lambdas, drops duplicated tests, changes test count |
Comments suppressed due to low confidence (1)
tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/Tests/Basic/BasicTestsBase.cs:137
- [nitpick] The test count was reduced from 156055 to 56055 without any explanation. Please add a comment clarifying why the workload size was changed or update the test name to reflect the new scale.
const int count = 56055;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.