Skip to content

Split merge tests and code cleanup#50

Merged
PhenX merged 1 commit intomainfrom
feature/split-merge-tests
Jun 1, 2025
Merged

Split merge tests and code cleanup#50
PhenX merged 1 commit intomainfrom
feature/split-merge-tests

Conversation

@PhenX
Copy link
Copy Markdown
Owner

@PhenX PhenX commented Jun 1, 2025

No description provided.

@PhenX PhenX requested a review from Copilot June 1, 2025 06:43
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR splits existing merge tests into provider-specific files and performs cleanup in the basic tests base class.

  • Adds separate MergeTests classes for Sqlite, SqlServer, PostgreSql, and MySql, each inheriting from the shared base.
  • Cleans up BasicTestsBase.cs: removes unused using, simplifies exclusion lambdas, deletes commented-out duplicate tests, and adjusts the test workload size.
  • Updates the many-entity insert test count and refactors some lambda parameter names.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/.../Merge/MergeTestsSqlite.cs New Sqlite-specific merge tests subclass
tests/.../Merge/MergeTestsSqlServer.cs New SqlServer-specific merge tests subclass
tests/.../Merge/MergeTestsPostgreSql.cs New PostgreSql-specific merge tests subclass
tests/.../Merge/MergeTestsMySql.cs New MySql-specific merge tests subclass
tests/.../Merge/MergeTestsBase.cs Introduces shared merge tests logic in a generic base
tests/.../Basic/BasicTestsBase.cs Removes unused import, simplifies lambdas, drops duplicated tests, changes test count
Comments suppressed due to low confidence (1)

tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/Tests/Basic/BasicTestsBase.cs:137

  • [nitpick] The test count was reduced from 156055 to 56055 without any explanation. Please add a comment clarifying why the workload size was changed or update the test name to reflect the new scale.
const int count = 56055;

@PhenX PhenX merged commit 481d4e8 into main Jun 1, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants