Conversation
Collaborator
SebastianStehle
left a comment
SebastianStehle
left a comment
There was a problem hiding this comment.
Looks good in general, but as mentioned a micro benchmark would be helpful. I cannot say, where exactly this would safe allocations. Perhaps less boxing? No idea.
Owner
Author
|
The allocation that can be prevented with this PR is the one made for the closures here : The big change is the use of I'll try to make a micro benchmark |
Owner
Author
|
@SebastianStehle here is the benchmark results, I think it will be hard to to better
|
Collaborator
|
Awesome, good job. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.