Geography fix#44
Merged
PhenX merged 8 commits intoPhenX:masterfrom May 26, 2025
Merged
Conversation
…workCore.BulkInsert into default-srid # Conflicts: # tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/Tests/Geo/GeoTestsBase.cs
…workCore.BulkInsert into geography-fix # Conflicts: # src/PhenX.EntityFrameworkCore.BulkInsert.PostgreSql/PostgreSqlGeometryConverter.cs # tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/Tests/Geo/GeoTestsBase.cs
Collaborator
Author
|
a release would be great |
PhenX
approved these changes
May 26, 2025
Owner
|
I can't right now, can you make it? v0.2.3 with a new tag like you did last time, but please generate the release notes with the button on the release form. |
Collaborator
Author
|
Done, didn't knew this button yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turned out that my whole geography stuff for Postgres was just wrong. You have to do nothing to get it working. With the conversion to binary the SRID was lost and therefore it was returning an error when making a query.
I added a test now to ensure that the geography can actually be used.
Sry for the mess with the commits again. I have to ensure that my next commit is made from master.