Improve tests#41
Merged
PhenX merged 4 commits intoPhenX:masterfrom May 25, 2025
Merged
Conversation
PhenX
reviewed
May 25, 2025
| var actualConfigure = configure ?? (_ => { }); | ||
| switch (strategy) | ||
| { | ||
| case InsertStrategy.InsertReturn: |
Owner
There was a problem hiding this comment.
My thought was to have two enums or two bools, but it works well like this too, as long as there are no more than two parameters
Collaborator
Author
|
I have found a case where the temporary tables in SQLite are not dropped properly. I am using a random identifier now and ensure that the tables are dropped. I think we should do this anyway, also for other providers. Because when you have a long custom transaction these temporary tables might exist longer than necessary. |
Owner
|
Good catch for the sqlite issue! |
Collaborator
Author
|
Yeah, when you find one bug with something like it is worth it :) |
Collaborator
Author
|
Tests are green again. I am done here. |
PhenX
approved these changes
May 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have implemented the test improvements with strategy pattern. I actually found a bug in sqlite. Therefore the tests are not green yet.