Logging#24
Merged
PhenX merged 4 commits intoPhenX:masterfrom May 22, 2025
Merged
Conversation
# Conflicts: # src/PhenX.EntityFrameworkCore.BulkInsert/BulkInsertProviderBase.cs
…workCore.BulkInsert into logging
Collaborator
Author
|
Also good to go. |
PhenX
reviewed
May 22, 2025
PhenX
approved these changes
May 22, 2025
Owner
|
Thank you for your contributions it's a pleasure ! |
Collaborator
Author
|
Are you planning a new nuget release? or do you want to add more things? |
Owner
|
I'm releasing a 0.1.0 |
Collaborator
Author
|
Awesome. I am going to test it out tomorrow :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up PR after Primary Keys.
I have added telemetry and logging.
I also reordered the methods in the base provider, because IMHO you should be able to read them top down.
And I found a small weirdness with connections in the provider so I also cleaned that up.
I think after this I have everything I would need for my app, but I am happy to contribute more if you assign tasks to me.