Conversation
|
I am not the biggest fan. My code is in general provide-agnostics. When you see an Insert(...) call you don't know which provider is actually behing that. I would only have the provider specific stuff in the Context (when I create multiple contexts, one per provider). If I have an Insert call, I would have three options: Option 1: No provider specific option at allMoves the options to the UseXYZCall() Option 2: Have the opportunity to provide all optionse.g. But this would create some coupling in my repositories and domain layer. Option 3: Have dedicated overridese.g. If a provider wants his own option, it should also provide it own overrides for extension method, otherwise the whole option thing is not type safe. |
# Conflicts: # src/PhenX.EntityFrameworkCore.BulkInsert.MySql/MySqlBulkInsertProvider.cs # src/PhenX.EntityFrameworkCore.BulkInsert.SqlServer/SqlServerBulkInsertProvider.cs # src/PhenX.EntityFrameworkCore.BulkInsert.Sqlite/SqliteBulkInsertProvider.cs # src/PhenX.EntityFrameworkCore.BulkInsert/Abstractions/IBulkInsertProvider.cs # src/PhenX.EntityFrameworkCore.BulkInsert/BulkInsertProviderBase.cs # src/PhenX.EntityFrameworkCore.BulkInsert/PhenX.EntityFrameworkCore.BulkInsert.csproj
|
I think this would also be fine. I would go with Option 1 and your alternative then. |
# Conflicts: # src/PhenX.EntityFrameworkCore.BulkInsert.MySql/MySqlBulkInsertProvider.cs # src/PhenX.EntityFrameworkCore.BulkInsert.SqlServer/SqlServerBulkInsertProvider.cs # src/PhenX.EntityFrameworkCore.BulkInsert.Sqlite/SqliteBulkInsertProvider.cs # src/PhenX.EntityFrameworkCore.BulkInsert/BulkInsertProviderBase.cs # src/PhenX.EntityFrameworkCore.BulkInsert/Extensions/DbSetExtensions.cs # tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/Tests/Basic/BasicTestsBase.cs
SebastianStehle
left a comment
There was a problem hiding this comment.
I have one comment that has not necessarily something todo with this PR.
|
Ok, I'll move it in the future, to the root namespace |
|
Is it ok for you ? it seems I cannot merge it without your approval 😅 |
|
Yes. But please make squash merges. my commits are not very clean and now the history is a little bit broken. Have not realized it before. I have no button to press, no idea why you cannot merge. I have resolved all conversations. Perhaps tis was the culprit? |

Fixes #8