Conversation
|
Why have you removed EFCore_SaveChanges. I think most people are interested in this. Alos needs an update for MySQL |
|
Yeah, I hesitated to let it, but it takes so much time... |
|
I think I'll change N to 100 000, do you think it's enough ? results are pretty linear between 100K, 1M or 10M |
|
I only added the benchmark, but had no patient to run it through. I would disable or reduce all the warmup stuff and just make one run, because it has very little bit benefit in this case. I would go to 1M |
# Conflicts: # tests/PhenX.EntityFrameworkCore.BulkInsert.Benchmark/LibComparator.cs # tests/PhenX.EntityFrameworkCore.BulkInsert.Benchmark/PhenX.EntityFrameworkCore.BulkInsert.Benchmark.csproj
…ht with provider specific import and simplify benchmark
…g it right with provider specific import and simplify benchmark" This reverts commit 0ba0264.
|
BulkExtensions work with MySQL. Why is there N/A? Otherwise: LGTM |
|
There is an error from the lib, I did not investigate further. Anyway we are still far ahead of others :) |
|
Yes. 90% is because you have decided to use the Reader and not data tables. Which was a very good decision. The rest is probably irrelevant. |
|
Yeah, but https://entityframework-extensions.net/ use data readers too, so that's weird. Anyway that's great! We'll try to keep the first place |
|
@SebastianStehle just to be sure about our results vs ef extensions, I made a fork of their benchmark ok .net fiddle I'm reassured
|
|
Nice |
3 participants
No description provided.