Metadata#19
Merged
PhenX merged 4 commits intoPhenX:masterfrom May 22, 2025
Merged
Conversation
PhenX
reviewed
May 21, 2025
Owner
PhenX
left a comment
PhenX
left a comment
There was a problem hiding this comment.
That's a lot of changes ! but I'm ok with it
…workCore.BulkInsert into metadata # Conflicts: # src/PhenX.EntityFrameworkCore.BulkInsert.Sqlite/SqliteBulkInsertProvider.cs # src/PhenX.EntityFrameworkCore.BulkInsert/BulkInsertProviderBase.cs
Collaborator
Author
|
I am done here as well. |
Merged
Collaborator
Author
|
tyvm. Can it be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not done and tested yet. I have extracted all the metadata part to its own structures. This makes it easier to reuse stuff and improves performance because we can actually save a lot of allocations.
Wanted to have your opinion before I complete it.