Skip to content

Expose the max_loops parameter - #428

Merged
thomaswilliamsastro merged 1 commit into
masterfrom
expose-max-loops
Nov 18, 2026
Merged

thomaswilliamsastro merged 1 commit into
masterfrom
expose-max-loops

Conversation

@thomaswilliamsastro

Copy link
Copy Markdown
Collaborator

Fixes #423

Exposes the max_loops parameter used in imaging at the Imaging/ChunkedImaging handler level. Sometimes this needs to be tuned up for bright targets, and was hardcoded. By defaults, stays at the value of 20 we were using before

@codecov

codecov Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 12.40%. Comparing base (34d000b) to head (100906b).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #428   +/-   ##
=======================================
  Coverage   12.40%   12.40%           
=======================================
  Files          43       43           
  Lines       17190    17190           
  Branches     4068     4068           
=======================================
  Hits         2132     2132           
  Misses      14824    14824           
  Partials      234      234           
Components Coverage Δ
casa 4.93% <ø> (ø)
handler 14.38% <ø> (ø)
spectral-cube 10.16% <ø> (ø)
utils 20.28% <ø> (ø)

@thomaswilliamsastro

Copy link
Copy Markdown
Collaborator Author

@e-koch Finally, a small PR!

Fixes #423

Exposes the `max_loops` parameter used in imaging at the Imaging/ChunkedImaging handler level. Sometimes this needs to be tuned up for bright targets, and was hardcoded. By defaults, stays at the value of 20 we were using before
@e-koch

e-koch commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

Good to merge when the tests pass!

@thomaswilliamsastro
thomaswilliamsastro merged commit 598d654 into master Nov 18, 2026
8 checks passed
@thomaswilliamsastro
thomaswilliamsastro deleted the expose-max-loops branch November 18, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose max_loops for imaging

2 participants