Repository navigation
Expose the max_loops parameter - #428
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #428 +/- ##
=======================================
Coverage 12.40% 12.40%
=======================================
Files 43 43
Lines 17190 17190
Branches 4068 4068
=======================================
Hits 2132 2132
Misses 14824 14824
Partials 234 234
|
Collaborator
Author
|
@e-koch Finally, a small PR! |
Fixes #423 Exposes the `max_loops` parameter used in imaging at the Imaging/ChunkedImaging handler level. Sometimes this needs to be tuned up for bright targets, and was hardcoded. By defaults, stays at the value of 20 we were using before
thomaswilliamsastro
force-pushed
the
expose-max-loops
branch
from
November 18, 2026 14:32
7e64b69 to
100906b
Compare
e-koch
approved these changes
Nov 18, 2026
Collaborator
|
Good to merge when the tests pass! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #423
Exposes the
max_loopsparameter used in imaging at the Imaging/ChunkedImaging handler level. Sometimes this needs to be tuned up for bright targets, and was hardcoded. By defaults, stays at the value of 20 we were using before