Skip to content

Set singlescale_mask_absolute=True by default - #418

Merged
thomaswilliamsastro merged 2 commits into
PhangsTeam:masterfrom
e-koch:singlescale_mask_absolute_True
Nov 12, 2026
Merged

thomaswilliamsastro merged 2 commits into
PhangsTeam:masterfrom
e-koch:singlescale_mask_absolute_True

Conversation

@e-koch

@e-koch e-koch commented Nov 10, 2026

Copy link
Copy Markdown
Collaborator

Addresses #415.

This addresses a difference in the default imaging parameters set by the pipeline vs used in practice for the PHANGS CO processing. singlescale_mask_absolute=True was always set in the imaging script, rather than the defaults in the imaging recipe function.

The issue that began creeping up was over-cleaning in the single-scale step as the single-scale mask was too permissive, even in the noise-only case. As a result, the cleaning would introduce a positive bias in the model flux from cleaning the noise peaks.

@codecov

codecov Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 12.44%. Comparing base (ebf9ba3) to head (818030a).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #418      +/-   ##
==========================================
- Coverage   12.45%   12.44%   -0.01%     
==========================================
  Files          43       43              
  Lines       16980    16980              
  Branches     4028     4028              
==========================================
- Hits         2115     2114       -1     
  Misses      14631    14631              
- Partials      234      235       +1     
Components Coverage Δ
casa 4.79% <ø> (-0.03%) ⬇️
handler 14.45% <ø> (ø)
spectral-cube 10.16% <ø> (ø)
utils 20.28% <ø> (ø)

@thomaswilliamsastro thomaswilliamsastro left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomaswilliamsastro
thomaswilliamsastro force-pushed the singlescale_mask_absolute_True branch from 0cb0af2 to 818030a Compare November 12, 2026 10:44
@thomaswilliamsastro

Copy link
Copy Markdown
Collaborator

Fails here seem to just be due to the NRAO bitbucket being down/slow. Everything was green earlier

@thomaswilliamsastro
thomaswilliamsastro merged commit b96bbc6 into PhangsTeam:master Nov 12, 2026
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants