Repository navigation
Set singlescale_mask_absolute=True by default - #418
Merged
thomaswilliamsastro merged 2 commits intoNov 12, 2026
Merged
thomaswilliamsastro merged 2 commits into
thomaswilliamsastro merged 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #418 +/- ##
==========================================
- Coverage 12.45% 12.44% -0.01%
==========================================
Files 43 43
Lines 16980 16980
Branches 4028 4028
==========================================
- Hits 2115 2114 -1
Misses 14631 14631
- Partials 234 235 +1
|
thomaswilliamsastro
force-pushed
the
singlescale_mask_absolute_True
branch
from
November 12, 2026 10:44
0cb0af2 to
818030a
Compare
Collaborator
|
Fails here seem to just be due to the NRAO bitbucket being down/slow. Everything was green earlier |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #415.
This addresses a difference in the default imaging parameters set by the pipeline vs used in practice for the PHANGS CO processing.
singlescale_mask_absolute=Truewas always set in the imaging script, rather than the defaults in the imaging recipe function.The issue that began creeping up was over-cleaning in the single-scale step as the single-scale mask was too permissive, even in the noise-only case. As a result, the cleaning would introduce a positive bias in the model flux from cleaning the noise peaks.