Repository navigation
Allow override parameters in chunked imaging handler - #417
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Default override checking unnecessarily recalculates unchanged dimensions, allowing floating-point error to inflate 768 pixels to 770 and alter the image grid, losing the estimator’s FFT-friendly size.
1 open issue
What changed in this PR
This PR adds override-file support to the chunked imaging handler, giving users control over pixel size and field-of-view dimensions, similar to the original imaging handler.
Changes:
- Adds a default-enabled
check_overridesoption. - Applies
cell,deltara, anddeltadecoverrides using target/configuration/product precedence. - Removes a verbose progress print from cube splitting.
| File | Description |
|---|---|
phangsPipeline/handlerImagingChunked.py |
Adds override lookup and image-dimension recalculation for chunked imaging. |
Review effort: Balanced
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #417 +/- ##
==========================================
- Coverage 12.52% 12.49% -0.03%
==========================================
Files 43 43
Lines 16875 16908 +33
Branches 4004 4014 +10
==========================================
Hits 2113 2113
- Misses 14528 14561 +33
Partials 234 234
|
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
@astrojysun Looks good to me, just to confirm that this will fall back the auto-generated values if the overrides aren't in the keys? And make sure to add a changelog entry (with the PR number) |
|
Yes, the Copilot review above caught an issue with preserving the autogenerated values, which is now fixed. I also updated the changelog. |

This mirrors the behavior in the original imaging handler and gives direct control over pixel and image sizes, which can also help speed up imaging (by reducing empty margins around the actual FoV).
Example entries in the override file:
ngc0253_6_12m+7m cell 0.1ngc0253_6_12m+7m deltara 360ngc0253_6_12m+7m deltadec 360