Skip to content

Allow override parameters in chunked imaging handler - #417

Merged
thomaswilliamsastro merged 3 commits into
PhangsTeam:masterfrom
astrojysun:js_dev
Nov 10, 2026
Merged

thomaswilliamsastro merged 3 commits into
PhangsTeam:masterfrom
astrojysun:js_dev

Conversation

@astrojysun

Copy link
Copy Markdown
Collaborator

This mirrors the behavior in the original imaging handler and gives direct control over pixel and image sizes, which can also help speed up imaging (by reducing empty margins around the actual FoV).

Example entries in the override file:

ngc0253_6_12m+7m cell 0.1
ngc0253_6_12m+7m deltara 360
ngc0253_6_12m+7m deltadec 360

Copilot AI balanced review requested due to automatic review settings November 5, 2026 16:20

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Default override checking unnecessarily recalculates unchanged dimensions, allowing floating-point error to inflate 768 pixels to 770 and alter the image grid, losing the estimator’s FFT-friendly size.

1 open issue
What changed in this PR

This PR adds override-file support to the chunked imaging handler, giving users control over pixel size and field-of-view dimensions, similar to the original imaging handler.

Changes:

  • Adds a default-enabled check_overrides option.
  • Applies cell, deltara, and deltadec overrides using target/configuration/product precedence.
  • Removes a verbose progress print from cube splitting.
File Description
phangsPipeline/​handlerImagingChunked.py Adds override lookup and image-dimension recalculation for chunked imaging.

Review effort: Balanced

Comment thread phangsPipeline/handlerImagingChunked.py Resolved
@codecov

codecov Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 2.50000% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 12.49%. Comparing base (4499bde) to head (3a64703).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #417      +/-   ##
==========================================
- Coverage   12.52%   12.49%   -0.03%     
==========================================
  Files          43       43              
  Lines       16875    16908      +33     
  Branches     4004     4014      +10     
==========================================
  Hits         2113     2113              
- Misses      14528    14561      +33     
  Partials      234      234              
Components Coverage Δ
casa 4.83% <ø> (ø)
handler 14.47% <2.50%> (-0.08%) ⬇️
spectral-cube 10.16% <ø> (ø)
utils 20.28% <ø> (ø)

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@thomaswilliamsastro

Copy link
Copy Markdown
Collaborator

@astrojysun Looks good to me, just to confirm that this will fall back the auto-generated values if the overrides aren't in the keys? And make sure to add a changelog entry (with the PR number)

@astrojysun

Copy link
Copy Markdown
Collaborator Author

Yes, the Copilot review above caught an issue with preserving the autogenerated values, which is now fixed.

I also updated the changelog.

@thomaswilliamsastro
thomaswilliamsastro merged commit f75c8d5 into PhangsTeam:master Nov 10, 2026
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants