Repository navigation
Support for gridding full singledish mosaics - #414
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #414 +/- ##
==========================================
- Coverage 12.49% 12.45% -0.05%
==========================================
Files 43 43
Lines 16908 16980 +72
Branches 4014 4028 +14
==========================================
+ Hits 2113 2115 +2
- Misses 14561 14631 +70
Partials 234 234
|
thomaswilliamsastro
force-pushed
the
sd-grid-together
branch
2 times, most recently
from
October 27, 2026 16:21
d01addb to
5770224
Compare
thomaswilliamsastro
force-pushed
the
sd-grid-together
branch
from
November 1, 2026 09:16
5770224 to
355b848
Compare
thomaswilliamsastro
force-pushed
the
sd-grid-together
branch
2 times, most recently
from
November 9, 2026 13:53
4a6b866 to
9a4c6d5
Compare
thomaswilliamsastro
marked this pull request as ready for review
November 9, 2026 19:17
Collaborator
Author
|
@low-sky Ready for review! |
thomaswilliamsastro
force-pushed
the
sd-grid-together
branch
from
November 10, 2026 09:23
9a4c6d5 to
c9f2aba
Compare
This PR adds support for combining multiple different TP mosaics together at once. It essentially loops over each MOUS, performing the calibration, before splitting out the field name (as defined in the ms_keys) and performing one big tsdimaging call at the end. This seems to be performing better than trying to linearly mosaic at the end. Because the imsize is set directly from the image, the phase centre is also no longer passed along to tsdimaging, to avoid potential mismatches leading to the edges being cut off. This is important for the way we have things set up, where individual tiles have their own coordinates separate from the full mosaic centre. It also takes a bit of time to try and improve on the "overwrite" switch in the pipeline. If False it should now just zoom through and not do any heavy processing. Default remains True, for backwards compatibility. - Add support for gridding multiple mosaics in the SD pipeline - Do a better job with the overwrite switch for the SD pipeline - Force phase centre to centre of fields in image
thomaswilliamsastro
force-pushed
the
sd-grid-together
branch
from
November 10, 2026 09:24
c9f2aba to
356036b
Compare
low-sky
reviewed
Nov 11, 2026
low-sky
approved these changes
Nov 11, 2026
Collaborator
Author
|
Merged, and opened up an issue #420 (blaze it) for the huge singledish images. Hopefully it's easy to find the offenders |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for combining multiple different TP mosaics together at once. It essentially loops over each MOUS, performing the calibration, before splitting out the field name (as defined in the ms_keys) and performing one big tsdimaging call at the end. This seems to be performing better than trying to linearly mosaic at the end.
Because the imsize is set directly from the image, the phase centre is also no longer passed along to tsdimaging, to avoid potential mismatches leading to the edges being cut off. This is important for the way we have things set up, where individual tiles have their own coordinates separate from the full mosaic centre.
It also takes a bit of time to try and improve on the "overwrite" switch in the pipeline. If False it should now just zoom through and not do any heavy processing. Default remains True, for backwards compatibility.
NGC7793:
NGC253: