Skip to content

Support for gridding full singledish mosaics - #414

Merged
thomaswilliamsastro merged 2 commits into
masterfrom
sd-grid-together
Nov 11, 2026
Merged

thomaswilliamsastro merged 2 commits into
masterfrom
sd-grid-together

Conversation

@thomaswilliamsastro

@thomaswilliamsastro thomaswilliamsastro commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

This PR adds support for combining multiple different TP mosaics together at once. It essentially loops over each MOUS, performing the calibration, before splitting out the field name (as defined in the ms_keys) and performing one big tsdimaging call at the end. This seems to be performing better than trying to linearly mosaic at the end.

Because the imsize is set directly from the image, the phase centre is also no longer passed along to tsdimaging, to avoid potential mismatches leading to the edges being cut off. This is important for the way we have things set up, where individual tiles have their own coordinates separate from the full mosaic centre.

It also takes a bit of time to try and improve on the "overwrite" switch in the pipeline. If False it should now just zoom through and not do any heavy processing. Default remains True, for backwards compatibility.

NGC7793:

image

NGC253:

Screenshot 2026-11-09 at 19 16 28
  • Add support for gridding multiple mosaics in the SD pipeline
  • Do a better job with the overwrite switch for the SD pipeline
  • Force phase centre to centre of fields in image

@codecov

codecov Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 3.77358% with 102 lines in your changes missing coverage. Please review.
✅ Project coverage is 12.45%. Comparing base (f75c8d5) to head (179e628).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #414      +/-   ##
==========================================
- Coverage   12.49%   12.45%   -0.05%     
==========================================
  Files          43       43              
  Lines       16908    16980      +72     
  Branches     4014     4028      +14     
==========================================
+ Hits         2113     2115       +2     
- Misses      14561    14631      +70     
  Partials      234      234              
Components Coverage Δ
casa 4.81% <4.39%> (-0.03%) ⬇️
handler 14.45% <0.00%> (-0.02%) ⬇️
spectral-cube 10.16% <ø> (ø)
utils 20.28% <ø> (ø)

@thomaswilliamsastro
thomaswilliamsastro force-pushed the sd-grid-together branch 2 times, most recently from d01addb to 5770224 Compare October 27, 2026 16:21
@thomaswilliamsastro
thomaswilliamsastro force-pushed the sd-grid-together branch 2 times, most recently from 4a6b866 to 9a4c6d5 Compare November 9, 2026 13:53
@thomaswilliamsastro
thomaswilliamsastro marked this pull request as ready for review November 9, 2026 19:17
@thomaswilliamsastro

Copy link
Copy Markdown
Collaborator Author

@low-sky Ready for review!

This PR adds support for combining multiple different TP mosaics together at once. It essentially loops over each MOUS, performing the calibration, before splitting out the field name (as defined in the ms_keys) and performing one big tsdimaging call at the end. This seems to be performing better than trying to linearly mosaic at the end.

Because the imsize is set directly from the image, the phase centre is also no longer passed along to tsdimaging, to avoid potential mismatches leading to the edges being cut off. This is important for the way we have things set up, where individual tiles have their own coordinates separate from the full mosaic centre.

It also takes a bit of time to try and improve on the "overwrite" switch in the pipeline. If False it should now just zoom through and not do any heavy processing. Default remains True, for backwards compatibility.

- Add support for gridding multiple mosaics in the SD pipeline
- Do a better job with the overwrite switch for the SD pipeline
- Force phase centre to centre of fields in image
@thomaswilliamsastro

Copy link
Copy Markdown
Collaborator Author

Merged, and opened up an issue #420 (blaze it) for the huge singledish images. Hopefully it's easy to find the offenders

@thomaswilliamsastro
thomaswilliamsastro merged commit ebf9ba3 into master Nov 11, 2026
7 of 8 checks passed
@thomaswilliamsastro
thomaswilliamsastro deleted the sd-grid-together branch November 11, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants