Restart R keeps the page - #56
Merged
Merged
Conversation
Restart R remounted every route, which wiped the page like a reload. Lesson and workspace sessions now rebuild their environment on the new R in place, so code, outputs and scroll position stay.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: clicking Restart R remounted the whole page, so it looked like a reload. Edited code, outputs and scroll position were lost.
After: only R restarts. The page, the code a student typed, earlier outputs and the scroll position all stay, and Run works again once R is ready.
How: App no longer keys the routes on a restart counter. useLessonSession listens for restarts and rebuilds its environment on the new R, which the lesson pages and the R Workspace already pick up.