Audit the model chooser and the sample size page - #54
Merged
Merged
Conversation
…r f, partial eta squared, simulation scale and alpha
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: the model chooser and the sample size page named t-tests, ANOVAs, chi-square and rank tests as if they were the method, next to the course's models.
After: every such name reads as "traditional" (for example "the traditional paired t-test"), and a unit test fails if a bare name comes back.
How: the text in modelTree.ts, questionMatcher.ts, sampleSizeDesigns.ts and SampleSize.tsx is rewritten, and the "Traditional name" label is now "Traditional counterpart". The report sentence on the sample size page now names the model's test first, with the traditional test in brackets. A strict correctness audit of both pages follows in this PR.