Allow metadata files with a single MediaInfo track#771
Conversation
Currently, our metadata attacher lambda expects a MediaInfo object in the metadata file to contain multiple tracks. This isn't always the case, so this commit updates the lambda to accept metadata files with only one track.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #771 +/- ##
=======================================
Coverage 98.55% 98.55%
=======================================
Files 109 109
Lines 2777 2777
Branches 465 466 +1
=======================================
Hits 2737 2737
Misses 36 36
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
cecilia-donnelly
left a comment
cecilia-donnelly
left a comment
There was a problem hiding this comment.
Okay, this makes perfect sense! Thanks!
I do worry that the overall extraction is a bit fragile, given that it looks like there are several different specific metadata errors (though they seem to be the same general type-mismatch problem) in Sentry. What's your sense of how resilient the process is at the moment? Do individual types of metadata fail individually, or if one fails does the whole process stop?
|
I didn't run this, since the code change struck me as extremely straightforward and I didn't immediately find an obvious way to create a test file (video/audio, not just the metadata as in the fixture) with just one of these tracks. |
2 participants
Currently, our metadata attacher lambda expects a MediaInfo object in the metadata file to contain multiple tracks. This isn't always the case, so this commit updates the lambda to accept metadata files with only one track.