Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ add_library(lib_opensslpp STATIC ${opensslpp_source_files})
target_link_libraries(lib_opensslpp
PRIVATE
binlog_server_compiler_flags
OpenSSL::Crypto
Boost::headers OpenSSL::Crypto
)
# it is not possible to propagate CXX_EXTENSIONS and CXX_STANDARD_REQUIRED
# via interface library (binlog_server_compiler_flags)
Expand Down Expand Up @@ -594,6 +594,7 @@ target_link_libraries(binlog_server
binsrv::lib_gtids
binsrv::lib_events
binsrv::lib_models
binsrv::lib_opensslpp
Boost::headers Boost::json Boost::url
aws-cpp-sdk-s3-crt
)
Expand Down
2 changes: 2 additions & 0 deletions src/binsrv/encryption_config.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ void encryption_config::validate() const {
util::exception_location().raise<std::invalid_argument>(
"error validating storage encryption config: unsupported format");
}
// TODO: make sure that data encryption cipher is supported by OpenSSL
// and has CTR mode
}

} // namespace binsrv
8 changes: 8 additions & 0 deletions src/binsrv/keyring_record_collection.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,14 @@ void keyring_record_collection::validate() const {
util::exception_location().raise<std::invalid_argument>(
"unsupported keyring record collection version");
}
// TODO: make sure that all the keys have unique IDs

// TODO: make sure that all keys have ciphers known in OpenSSL
// (currently only ECB, CBC, CTR, GCM modes are supported by
// opensslpp::cipher_context)

// TODO: make sure that all keys have data_hex values of the correct length
// that matches with the cipher
}

[[nodiscard]] std::string keyring_record_collection::get_description() const {
Expand Down
Loading
Loading