Render settings from the device-reported schema - #4
Draft
chrispmonkey wants to merge 2 commits into
Draft
Conversation
chrispmonkey
force-pushed
the
settings-schema
branch
from
August 3, 2026 23:46
f6abf09 to
2e164de
Compare
Author
|
Updated to write through the existing typed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renders the settings form from the device's
GET /api/settings/schemadescriptorinstead of hardcoding each field in
SettingsPage.tsx. A new setting the deviceadds shows up here with no client change.
The descriptor is sections of typed fields (
string/text/secret/bool/
enum);SchemaSettingsFormmaps each type to a control,visibleWhengatesconditional fields, and
secretfields stay write-only (the device reports onlyconfigured, so a save sends just what changed). Falls back to the existingfixed form when the device doesn't serve the descriptor.
Pairs with the server side (PenumbraOS/humane-system-hook#10), which emits the
descriptor.