Replace mssql_cbt with mssql_epa for full Extended Protection enforcement check#1209
Open
NoahDSJP wants to merge 1 commit intoPennyw0rth:mainfrom
Open
Replace mssql_cbt with mssql_epa for full Extended Protection enforcement check#1209NoahDSJP wants to merge 1 commit intoPennyw0rth:mainfrom
NoahDSJP wants to merge 1 commit intoPennyw0rth:mainfrom
Conversation
Member
|
Thanks for the PR! |
Contributor
|
Alright thanks for the PR! So here is the thing:
Let me know :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR description and any comments are written by me in Japanese
and translated to English using a translation tool (Google Translation).
This PR is a continuation of #1206.
Following @Dfte's suggestion to merge mssql_cbt and mssql_epa into a single module (and using mssql_epa as the name).
The purpose of this PR is to remove mssql_cbt and add the mssql_epa module, which performs more comprehensive EPA checks.
mssql_cbt only detects whether CBT is required.
mssql_epa is more comprehensive, distinguishing between three EPA enforcement levels (Off/Allowed/Required) and also covering SPN-based paths that apply when mandatory encryption is disabled. This cannot be checked with mssql_cbt.
mssql_epa functionality:
Detect EPA enforcement:
The tool this module is based on:
https://github.com/NoahDSJP/mssql_epa_check
Notes
Wiki updates will be submitted separately to https://github.com/Pennyw0rth/NetExec-Wiki
AI Assistance Disclosure
Developed using Claude Code (Anthropic, Opus 4.7).
All code has been manually reviewed and tested by me.
Type of change
Setup guide for the review
Reproduce:
Expected output (one of):
Screenshots (if appropriate):
Checklist:
poetry run ruff check ., use--fixto automatically fix what it can)tests/e2e_commands.txtfile if necessary (new modules or features are required to be added to the e2e tests)