Add exclude options based on @bdrogja's work #732#1204
Add exclude options based on @bdrogja's work #732#1204Dfte wants to merge 2 commits intoPennyw0rth:mainfrom
Conversation
|
Nice! Thanks for the work. |
|
@Marshall-Hallenbeck the PR description check crashed again |
I think because I removed the setup # |
Naa it should comment and yell at you, not fail to run |
|
Thinking of how I'd use this PR, I'd also add the options that were developed by @bdrojga vefor (--exlude-hosts and --skip-self) |
|
It looks like the PR template may not have been filled out. The following sections appear to be missing:
Please edit your PR description to include them. The template helps reviewers understand and test your changes. Thanks! |
Yes finally it's working :D |
|
I'll modify the PR and add the options as well when I got time :) |
Description
Opening this PR to continue @bdrogja work from #732.
This PR adds two new config options allowing to exclude some IP's from NetExec and excluding local IP's as well:
The exclude_hosts option is an array that can take multiple type of values:
For example:
As @bdrogja mentions, this PR also closes #674.
I don't know if the test.py part is relevant anymore tho.
Type of change
Insert an "x" inside the brackets for relevant items (do not delete options)
Checklist :
Insert an "x" inside the brackets for completed and relevant items (do not delete options)
poetry run ruff check ., use--fixto automatically fix what it can)tests/e2e_commands.txtfile if necessary (new modules or features are required to be added to the e2e tests)