[pob1-port] Add build comparison tab#1830
Open
vaisest wants to merge 14 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes from PathOfBuildingCommunity/PathOfBuilding#9543
Description of the problem being solved:
Ports changes, but also improves the trader functionality a lot. Previously (and this is true for PoB1 too) any mod with separate global and local trade filters would fail to match correctly, which meant searching most armour or weapons was not working well. Inverted mods, which say increased on the item, but are reduced with the value negated on the trade site, were also not supported.
These are both now supported. I have tested quite a few items, but given how there are a gazillion stats, it's possible some of them don't function. There are for example some things like the 4 desecration jewel which lack the correct base tags. Megalomaniac is also not supported, because the trade hash format is weird.
Steps taken to verify a working solution:
Tested combinations of the following builds:
The stats have not been verified super accurately, but they seem correct, and nothing has crashed.
Seems most of it is directly compatible with pob2, but various things are hidden behind different variables. These fixes mostly focus on fixing those mistakes. Skill sets were also added to the calcs tab.
Trade hash generation was also reworked. This probably means the trader tool will not generate QueryMods.lua correctly. I don't think anything else uses the tradehash field, though. The rework should correct A LOT of trade hashes. Many stats were being incorrectly concatenated, and most mods with multiple stats were wrong as concatenation is only correct for # to # mods which have a separate minimum and maximum stat