Skip to content

docs(dip-26): clarify payout list review feedback - #4

Merged
PastaPastaPasta merged 1 commit into
PastaPastaPasta:codex/masternode-reward-sharesfrom
thepastaclaw:fix/dip26-phez-feedback
Jul 15, 2026
Merged

docs(dip-26): clarify payout list review feedback#4
PastaPastaPasta merged 1 commit into
PastaPastaPasta:codex/masternode-reward-sharesfrom
thepastaclaw:fix/dip26-phez-feedback

Conversation

@thepastaclaw

Copy link
Copy Markdown

Summary

Addresses the latest DIP-26 review comments from thephez:

  • lists provider transaction version 3 as reserved/unused before version 4 in DIP-0003
  • clarifies that owner payouts use the same payout-list structure and must sum to 10000
  • states the payout list applies to regular masternodes and evonodes
  • documents the 100 basis-point minimum in the payout entry table
  • clarifies that a v4 ProUpRegTx can migrate an existing legacy masternode to a payout list

Validation

  • npx markdownlint-cli2 "dip-0003.md" "dip-0026.md" --config .markdownlint.json
  • Worktree-scoped pre-PR review gate: ship

@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 57c074d1-a3c0-48b8-8e85-644c3ad2e7d7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Comment thread dip-0003.md Outdated
| ------- | ------------------------------------------------------- |
| 1 | PubKeyOperator is serialised using legacy BLS scheme |
| 2 | PubKeyOperator is serialised using basic BLS scheme |
| 3 | Reserved, unused |

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thepastaclaw did you verify why 3 wasn't in the list? Because my comment on the original PR was just speculating on possible reasons.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I rechecked Dash Core instead of relying on the earlier speculation: provider tx version 3 is used for extended network information (ProTxVersion::ExtAddr = 3, introduced by the extended-address provider-tx work). I amended this row in 31d9c75 to describe v3 as extended network information serialization instead of reserved/unused.

Comment thread dip-0003.md Outdated
| ------- | ------------------------------------------------------- |
| 1 | PubKeyOperator is serialised using legacy BLS scheme |
| 2 | PubKeyOperator is serialised using basic BLS scheme |
| 3 | Reserved, unused |

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thepastaclaw did you verify why 3 wasn't in the list? Because my comment on the original PR was just speculating on possible reasons.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same recheck here: version 3 is not globally unused, but current Dash Core only enables the extended-network-information version for ProRegTx and ProUpServTx; ProUpRegTx still maxes at the basic-BLS version. I amended this row in 31d9c75 to say it is reserved for extended network information rather than unused.

@thepastaclaw
thepastaclaw force-pushed the fix/dip26-phez-feedback branch from af3847d to 31d9c75 Compare June 29, 2026 23:07
@PastaPastaPasta
PastaPastaPasta merged commit 5108628 into PastaPastaPasta:codex/masternode-reward-shares Jul 15, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants