docs(dip-26): clarify payout list review feedback - #4
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| | ------- | ------------------------------------------------------- | | ||
| | 1 | PubKeyOperator is serialised using legacy BLS scheme | | ||
| | 2 | PubKeyOperator is serialised using basic BLS scheme | | ||
| | 3 | Reserved, unused | |
There was a problem hiding this comment.
@thepastaclaw did you verify why 3 wasn't in the list? Because my comment on the original PR was just speculating on possible reasons.
There was a problem hiding this comment.
Good catch. I rechecked Dash Core instead of relying on the earlier speculation: provider tx version 3 is used for extended network information (ProTxVersion::ExtAddr = 3, introduced by the extended-address provider-tx work). I amended this row in 31d9c75 to describe v3 as extended network information serialization instead of reserved/unused.
| | ------- | ------------------------------------------------------- | | ||
| | 1 | PubKeyOperator is serialised using legacy BLS scheme | | ||
| | 2 | PubKeyOperator is serialised using basic BLS scheme | | ||
| | 3 | Reserved, unused | |
There was a problem hiding this comment.
@thepastaclaw did you verify why 3 wasn't in the list? Because my comment on the original PR was just speculating on possible reasons.
There was a problem hiding this comment.
Same recheck here: version 3 is not globally unused, but current Dash Core only enables the extended-network-information version for ProRegTx and ProUpServTx; ProUpRegTx still maxes at the basic-BLS version. I amended this row in 31d9c75 to say it is reserved for extended network information rather than unused.
af3847d to
31d9c75
Compare
5108628
into
PastaPastaPasta:codex/masternode-reward-shares
Summary
Addresses the latest DIP-26 review comments from thephez:
Validation
npx markdownlint-cli2 "dip-0003.md" "dip-0026.md" --config .markdownlint.jsonship