Skip to content

test(desktop): the text pick test sets the top view again before each click #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ManuelStaggl merged 2 commits into from
Nov 12, 2026
Merged

test(desktop): the text pick test sets the top view again before each click #360

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
560cd45
test(desktop): the text pick test sets the top view again before each…
ManuelStaggl Nov 12, 2026
8df84a8
test(desktop): the joint tests read the revision once no trial is reb…
ManuelStaggl Nov 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions apps/desktop/e2e/solidcraft.contract.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2976,6 +2976,9 @@ test('a built text is picked as a whole and changed afterwards: words, height an
await expect(async () => {
const [x, y] = spots[spot++ % spots.length] ?? [0.5, 0.5];
await page.keyboard.press('Escape');
// Again each time: the first key 7 is lost when the view was not ready for it, and every click then misses.
await page.keyboard.press('7');
await page.waitForTimeout(700);
await page.mouse.click(box.x + box.width * x, box.y + box.height * y);
await expect(page.getByTestId('logo-text')).toBeVisible({ timeout: 3000 });
}, 'the built text under a click').toPass({ timeout: 60_000, intervals: [500] });
Expand All @@ -3001,6 +3004,9 @@ test('a built text is picked as a whole and changed afterwards: words, height an
await expect(async () => {
const [x, y] = spots[spot++ % spots.length] ?? [0.5, 0.5];
await page.keyboard.press('Escape');
// Again each time: the first key 7 is lost when the view was not ready for it, and every click then misses.
await page.keyboard.press('7');
await page.waitForTimeout(700);
await page.mouse.click(box.x + box.width * x, box.y + box.height * y);
await expect(page.getByTestId('logo-words').getByRole('textbox')).toHaveValue('AB', { timeout: 3000 });
}, 'the changed text under a click').toPass({ timeout: 60_000, intervals: [500] });
Expand Down Expand Up @@ -3119,6 +3125,8 @@ test('a hinge the assistant joined moves with its slider and goes back to as des
return count;
});
expect(await turned()).toBe(0);
// Not while a trial still shows "rebuilding": the revision that stands is what the test compares with.
await expect(page.getByTestId('connection-status')).toHaveText(/Revision \d+/, { timeout: 30_000 });
const revision = await page.getByTestId('connection-status').textContent();
const track = await page.getByTestId('joint-value').locator('.relative').first().boundingBox();
if (!track) throw new Error('the slider has no track');
Expand Down Expand Up @@ -3189,6 +3197,8 @@ test('a hinge plays in the view, stops where SolidCraft found the parts touching
await page.keyboard.press('Escape');
await expect(findings).toBeHidden({ timeout: 1000 });
}).toPass({ timeout: 15_000 });
// Not while a trial still shows "rebuilding": the revision that stands is what the test compares with.
await expect(page.getByTestId('connection-status')).toHaveText(/Revision \d+/, { timeout: 30_000 });
const revision = await page.getByTestId('connection-status').textContent();
// One click plays it: down to its limit first (the longer way), then up until the parts touch.
await page.getByTestId('joints-play').click();
Expand Down