Update RBC plots#645
Open
brownbaerchen wants to merge 3 commits intoParallel-in-Time:masterfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Rayleigh–Bénard convection (RBC) project’s paper/validation plotting scripts to produce merged verification figures and documents how to regenerate them.
Changes:
- Adjusted verification plot layouts (aspect/size) for both microscopic and macroscopic validation figures.
- Added a new “microscopic verification” figure combining spectra and order-of-accuracy plots (and refactored plotting functions to accept an external axis).
- Expanded the RayleighBenard README with instructions for generating microscopic and macroscopic verification plots.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
pySDC/projects/RayleighBenard/analysis_scripts/compare_Nek5000.py |
Tweaks macroscopic verification figure sizing and enforces square subplot aspects. |
pySDC/projects/RayleighBenard/analysis_scripts/RBC3D_spectrum.py |
Refactors spectra plotting to be embeddable and adds combined microscopic verification plot generation. |
pySDC/projects/RayleighBenard/analysis_scripts/RBC3D_order.py |
Refactors order-plot routine to support embedding in a multi-panel figure and updates plotted series/labeling. |
pySDC/projects/RayleighBenard/README.rst |
Adds step-by-step instructions for generating microscopic/macroscopic verification plots. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - ``--res=64 --dt=0.01 --config=RBC3DG4R4SDC23Ra1e6`` | ||
| - ``--res=128 --dt=0.005 --config=RBC3DG4R4SDC23Ra1e7`` | ||
|
|
||
| The, just run |
There was a problem hiding this comment.
Typo in the instructions: "The, just run" should be "Then, just run" (or "Then just run") to read correctly.
Suggested change
| The, just run | |
| Then, just run |
| Plotting macroscopic verification | ||
| --------------------------------- | ||
| Macroscopic verification is done via comparison with data from https://doi.org/10.5281/zenodo.14205874. | ||
| You need to download this reference dataset and copy it to `pySDC/projects/RayleighBenard/data/Nek5000`. |
There was a problem hiding this comment.
The path is wrapped in single backticks, which in reStructuredText creates interpreted text and can render incorrectly. Use inline-literal markup (double backticks) here to match the rest of the README and avoid formatting warnings.
Suggested change
| You need to download this reference dataset and copy it to `pySDC/projects/RayleighBenard/data/Nek5000`. | |
| You need to download this reference dataset and copy it to ``pySDC/projects/RayleighBenard/data/Nek5000``. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small updates to RBC paper plots: Merge spectrum and order plots, change size of macroscopic validation plot and add instructions for generating both validation plots.