Addressed warnings about deprecated utcnow usage#53
Open
fbarreir wants to merge 5 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates worker-node scripts to avoid deprecated datetime.datetime.utcnow() / utcfromtimestamp() usage by introducing helper functions that produce equivalent naive UTC datetime values without triggering deprecation warnings on newer Python versions.
Changes:
- Added
naive_utcnow()andnaive_utcfromtimestamp()helpers inpandawnutil.wnmisc.misc_utils. - Replaced direct
utcnow()calls inrunGen.pyandrunAthena.pywithnaive_utcnow(). - Updated checkpoint uploader file mtime handling to use
naive_utcfromtimestamp()and checkpoint timestamps to usenaive_utcnow().
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/rungen/runGen.py |
Switches build/result timestamp printing from deprecated utcnow() to naive_utcnow(). |
src/runathena/runAthena.py |
Switches build/result timestamp printing from deprecated utcnow() to naive_utcnow(). |
pandawnutil/wnmisc/misc_utils.py |
Introduces UTC helper functions and applies them to checkpoint uploader time comparisons. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.