Postprocessing#735
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves clarity and maintainability of JEDI post-processing code by adding module/class/method docstrings and tightening inline comments, plus some light refactoring of variable naming and control flow in the post-processing daemon loop.
Changes:
- Added descriptive docstrings to ATLAS production/analysis post-processors and the JEDI PostProcessor worker/threads.
- Refactored
PostProcessor.start()variable naming and loop structure for readability. - Clarified (and reworded) several inline comments around dataset handling, email notification, and task lifecycle steps.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
pandajedi/jedipprocess/AtlasProdPostProcessor.py |
Adds docstrings/comments describing production post-processing steps (with one doc step needing correction). |
pandajedi/jedipprocess/AtlasAnalPostProcessor.py |
Adds docstrings/comments for analysis post-processing and email notification flow (with doc/inline-comment mismatches to fix). |
pandajedi/jediorder/PostProcessor.py |
Adds module/class/method docstrings and refactors the daemon loop/worker code; introduces a real exception-handling hazard to fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
81
to
+83
| except Exception: | ||
| errtype, errvalue = sys.exc_info()[:2] | ||
| tmpLog.error(f"failed in {self.__class__.__name__}.start() with {errtype.__name__} {errvalue}") | ||
| # sleep if needed | ||
| loopCycle = 60 | ||
| timeDelta = naive_utcnow() - startTime | ||
| sleepPeriod = loopCycle - timeDelta.seconds | ||
| if sleepPeriod > 0: | ||
| time.sleep(sleepPeriod) | ||
| err_type, err_value = sys.exc_info()[:2] | ||
| tmp_log.error(f"failed in {self.__class__.__name__}.start() with {err_type.__name__} {err_value}") |
Comment on lines
+86
to
+90
| loop_cycle = 60 | ||
| elapsed = naive_utcnow() - start_time | ||
| sleep_period = loop_cycle - elapsed.seconds | ||
| if sleep_period > 0: | ||
| time.sleep(sleep_period) |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.