uppercase the database schema#719
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes schema prefixes in embedded SQL to uppercase (e.g., ATLAS_PANDA.) so the server’s schema-rewrite logic can consistently substitute the configured schema names across different DB backends/environments.
Changes:
- Updated several SQL statements to use uppercase schema prefixes (
ATLAS_PANDA,ATLAS_PANDAARCH) for compatibility with schema substitution. - Improved
async_update_datasetsexception logging to distinguish NOWAIT/lock-contention cases. - Made the adder daemon’s worker count configurable via
argv[2]and reflected it in logs.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| pandaserver/test/daod_on_demand.py | Uppercases ATLAS_PANDA schema prefix in a test query. |
| pandaserver/test/boostUser.py | Uppercases ATLAS_PANDA schema prefix in update statements. |
| pandaserver/taskbuffer/db_proxy_mods/worker_module.py | Uppercases schema prefixes in CPU benchmark lookup query. |
| pandaserver/taskbuffer/db_proxy_mods/misc_standalone_module.py | Uppercases schema prefixes in archive checks; tweaks exception handling/logging for async dataset updates. |
| pandaserver/taskbuffer/db_proxy_mods/entity_module.py | Uppercases schema prefixes in carbon and DDM mapping queries. |
| pandaserver/daemons/scripts/hs_scrapers.py | Uppercases schema prefixes for CPU benchmark inserts/selects. |
| pandaserver/daemons/scripts/add_main.py | Adds configurable worker/process count via CLI arg and updates logging accordingly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tmaeno
approved these changes
May 21, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update to use uppercase for the database schema, while will be replaced with the defined schema for different databases, such as postgresql.