Skip to content

uppercase the database schema#719

Merged
tmaeno merged 15 commits into
PanDAWMS:masterfrom
wguanicedew:NoWait
May 26, 2026
Merged

uppercase the database schema#719
tmaeno merged 15 commits into
PanDAWMS:masterfrom
wguanicedew:NoWait

Conversation

@wguanicedew
Copy link
Copy Markdown
Contributor

update to use uppercase for the database schema, while will be replaced with the defined schema for different databases, such as postgresql.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes schema prefixes in embedded SQL to uppercase (e.g., ATLAS_PANDA.) so the server’s schema-rewrite logic can consistently substitute the configured schema names across different DB backends/environments.

Changes:

  • Updated several SQL statements to use uppercase schema prefixes (ATLAS_PANDA, ATLAS_PANDAARCH) for compatibility with schema substitution.
  • Improved async_update_datasets exception logging to distinguish NOWAIT/lock-contention cases.
  • Made the adder daemon’s worker count configurable via argv[2] and reflected it in logs.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
pandaserver/test/daod_on_demand.py Uppercases ATLAS_PANDA schema prefix in a test query.
pandaserver/test/boostUser.py Uppercases ATLAS_PANDA schema prefix in update statements.
pandaserver/taskbuffer/db_proxy_mods/worker_module.py Uppercases schema prefixes in CPU benchmark lookup query.
pandaserver/taskbuffer/db_proxy_mods/misc_standalone_module.py Uppercases schema prefixes in archive checks; tweaks exception handling/logging for async dataset updates.
pandaserver/taskbuffer/db_proxy_mods/entity_module.py Uppercases schema prefixes in carbon and DDM mapping queries.
pandaserver/daemons/scripts/hs_scrapers.py Uppercases schema prefixes for CPU benchmark inserts/selects.
pandaserver/daemons/scripts/add_main.py Adds configurable worker/process count via CLI arg and updates logging accordingly.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pandaserver/taskbuffer/db_proxy_mods/misc_standalone_module.py
Comment thread pandaserver/taskbuffer/db_proxy_mods/misc_standalone_module.py
Comment thread pandaserver/daemons/scripts/add_main.py
Comment thread pandaserver/daemons/scripts/add_main.py
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@tmaeno tmaeno merged commit b602126 into PanDAWMS:master May 26, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants