Skip to content

fix: 加槓の牌姿が暗槓で描画されるバグ修正 + CI/Release 整備 (v0.2.1) - #1

Merged
k0kishima merged 10 commits into
mainfrom
develop
Jun 23, 2026
Merged

fix: 加槓の牌姿が暗槓で描画されるバグ修正 + CI/Release 整備 (v0.2.1)#1
k0kishima merged 10 commits into
mainfrom
develop

Conversation

@k0kishima

Copy link
Copy Markdown
Member

概要

点数計算ドリルで、加槓(Kakan)の牌姿が暗槓(裏-表-表-裏)として描画され、見た目は暗槓(32符)なのに正解は明槓(16符)前提となりユーザーが正答に辿り着けないバグを修正。あわせて CI/Release を新規整備。

変更

  • fix: Furo の暗槓判定を「furo なしカンツのみ」に修正。加槓・大明槓は副露(表向き)で描画。加槓の回帰テスト追加。
  • ci: CI(lint/typecheck/test/build) と Release(version 差分で publish → タグ → GitHub Release) を追加。publish は npm Trusted Publishing(OIDC) でトークン不要。
  • chore: @eslint/js 追加+既存 lint エラー11件を解消。旧 Tailwind class 前提で壊れていた Hai/Tehai テストを現行実装に合わせ修正。pnpm-lock.yaml を追跡化(再現性)。repository.url を PaiForge org に是正。version 0.2.0 → 0.2.1。

マージ後

main への push で Release ワークフローが走り、0.2.1 が自動 publish される。

k0kishima and others added 10 commits January 14, 2026 15:52
- pnpm-lock.yaml を削除し、package-lock.json を追加
- vitest を 4.x にアップグレード
- @pai-forge/riichi-mahjong を 0.3.1 にアップデート
- テスト環境で react-native を react-native-web にエイリアス

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Furo treated every kantsu except Daiminkan as a concealed ankan, so a
kakan was drawn with face-down tiles. In the scoring drill this made an
open kan (明槓 16符) look like a concealed ankan (暗槓 32符), so the
correct answer was unreachable from the tile image. Render only
furo-less kantsu with the ankan layout. Add kakan regression test.
Bump to 0.2.1.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
- Add CI (lint/typecheck/test/build) and Release workflows. Release
  publishes on main when package.json version is new, using npm Trusted
  Publishing (OIDC, no token), then tags vX.Y.Z and creates a Release.
- Add missing @eslint/js dev dep and fix 11 pre-existing lint errors
  (no-explicit-any, unused vars, type-only imports) in Hai/props.
- Update stale Hai/Tehai tests that asserted obsolete Tailwind classes
  to assert the actual react-native-web styling.
- Commit pnpm-lock.yaml (un-ignore) for reproducible --frozen-lockfile
  installs; fix repository.url to the PaiForge org.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@k0kishima
k0kishima merged commit 6cb4f75 into main Jun 23, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant