fix: separate model weights from inputs in extraction output#712
Closed
xjtu-L wants to merge 1 commit into
Closed
Conversation
|
Thanks for your contribution! |
4ba97fe to
5545875
Compare
Previously, `extractor.py` passed all placeholder params (including lifted parameters, buffers, SymInt symbols, and real inputs) to `convert_state_and_inputs(params, [])`, causing all of them to be written to `weight_meta.py`. This led to SymInt placeholders like `Program_weight_tensor_meta_s0` appearing in `weight_meta.py`, which are not real model weights. This change: - Collects `id()` of original model parameters and buffers in `wrapper()` - Passes them to `GraphExtractor` via `param_buffer_ids` - Splits `params` into `weights` (params/buffers by identity) and `example_inputs` (real inputs including SymInt) - Writes weights to `weight_meta.py` and inputs to `input_meta.py` - Updates `utils.py` to handle dict-style `example_inputs`
5545875 to
bb404cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extractor.pyto correctly separate model parameters/buffers from placeholder inputs (including SymInt symbols likes0,s1) when saving tensor metadataconvert_state_and_inputs(params, []), causing SymInt placeholders to appear inweight_meta.pyasProgram_weight_tensor_meta_s0id()) to distinguish original model params/buffers from real inputs, writing weights toweight_meta.pyand inputs toinput_meta.pyutils.pyto handle dict-styleexample_inputswith named tensor infosBackground
When
torch.compilewith FX tracing lifts model parameters and buffers into placeholder nodes, the extractor treated them identically to real model inputs. This caused:s0,s1, etc.) to be written toweight_meta.pyas fake weightsinput_meta.pyinstead ofweight_meta.py_get_tensor_metas) to merge both files, propagating the redundant entriesChanges
graph_net/torch/extractor.pyGraphExtractor.__init__: addparam_buffer_idsparameterwrapper(): collectid()of original model'snamed_parameters()andnamed_buffers(), pass toGraphExtractor__call__(): splitparamsintoweights(by id match) andexample_inputs, callconvert_state_and_inputs(weights, example_inputs)graph_net/torch/utils.pyconvert_state_and_inputs_impl: supportexample_inputsasdict(named inputs)save_converted_to_text: handle dict-of-tensor-infos forinput_info, preserving placeholder namesTest Plan
weight_meta.pyempty, all inputs ininput_meta.pyweight_meta.pyweight_meta.py, real inputs ininput_meta.pyweight_meta.pys0/s1SymInt symbols never appear inweight_meta.py