fix: allow ENEK5130 keyboard controls without legacy sysfs features - #248
Open
abduvaliy-hbai wants to merge 2 commits into
Open
fix: allow ENEK5130 keyboard controls without legacy sysfs features#248abduvaliy-hbai wants to merge 2 commits into
abduvaliy-hbai wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What happened
PR #213 added the ENEK5130 HID backend and correctly exposed the dedicated
enek5130_hid_rgbcapability. On laptops such as the Acer Nitro ANV16S-41,the daemon detects the HID controller while the legacy Linuwu-Sense
four_zoned_kbsysfs directory is absent.The remaining GUI, client, and daemon command gates still required the legacy
per_zone_modeorfour_zone_modecapability. As a result:because
has_four_zone_kbwas false;The logs therefore showed
enek5130_hid_rgbas available, but no HID featurereport could be triggered through DAMX.
Fix
enek5130_hid_rgbis available.RGB-capability check that accepts legacy sysfs or ENEK5130.
existing ENEK5130 implementation.
sysfs features that do not exist.
Verification
python3 -m py_compilepasses for all daemon Python files.The Avalonia solution builds and publishes successfully with .NET 9.
The daemon packages successfully with PyInstaller.
Tested on Acer Nitro ANV16S-41 with ENEK5130 at
/dev/hidraw8.get_supported_featuresreturnedenek5130_hid_rgbwithhas_four_zone_kb: false.A normal
set_four_zone_modesocket request returnedsuccess: trueandproduced the expected daemon log:
This closes the integration gap left after #213: detection and HID transport
were already working, but the feature gates made them unreachable.