Fix:Nav-bar#25
Open
Roniscend wants to merge 1 commit into
Open
Conversation
Signed-off-by: Owm Dubey <owmdubey163@gmail.com>
There was a problem hiding this comment.
Pull request overview
Updates the app’s navigation to adapt to different screen widths (Issue #14), switching between a bottom navigation bar on compact screens and a navigation rail on larger screens.
Changes:
- Add Material3 window size class dependency via the version catalog.
- Compute
WindowWidthSizeClassinMainActivityand select between bottom nav vs. nav rail layout. - Restructure the
Scaffoldcontent to support a side-by-side navigation + content layout.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
gradle/libs.versions.toml |
Adds the material3-window-size-class library alias to the version catalog. |
app/build.gradle.kts |
Pulls in the new window size class dependency for the app module. |
app/src/main/java/com/prauga/pvot/MainActivity.kt |
Uses window size class to conditionally render a bottom nav bar vs. a nav rail and adjusts layout accordingly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+95
to
+101
| if (useNavRail) { | ||
| PvotNavRail( | ||
| selectedTab = selectedTab, | ||
| onTabClick = { selectedTab = it }, | ||
| tabs = tabs | ||
| ) | ||
| } |
Comment on lines
43
to
48
| setPvotContent { | ||
| val windowSizeClass = calculateWindowSizeClass(this) | ||
| val dynamicColor by PreferencesManager.dynamicColorEnabled.collectAsState() | ||
| PvotAppTheme(dynamicColor = dynamicColor) { | ||
| DesignSystemShowcase() | ||
| DesignSystemShowcase(windowSizeClass.widthSizeClass) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #14
