Skip to content

Fix: Info icon in PvoTNavBar renders oval instead of circular#21

Open
Roniscend wants to merge 1 commit into
PVOT-OSS:mainfrom
Roniscend:Fix-Bar
Open

Fix: Info icon in PvoTNavBar renders oval instead of circular#21
Roniscend wants to merge 1 commit into
PVOT-OSS:mainfrom
Roniscend:Fix-Bar

Conversation

@Roniscend
Copy link
Copy Markdown

@Roniscend Roniscend commented Mar 9, 2026

This PR fixes the incorrect oval rendering of the info icon in the PvoTNavBar, ensuring it appears circular and consistent with the other navigation icons.
Fixes: #20
a

Copilot AI review requested due to automatic review settings March 9, 2026 17:07
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts PvotNavBar default sizing to prevent the info tab/icon from appearing oval by reducing overall horizontal padding and inter-item spacing so collapsed items have enough width to remain circular.

Changes:

  • Reduced PvotNavBarSizes.horizontalPadding default.
  • Reduced PvotNavBarSizes.contentPaddingHorizontal default.
  • Reduced PvotNavBarSizes.itemSpacing default.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@danascape
Copy link
Copy Markdown
Member

@Roniscend have you tested this in multiple resolutions?

Because on my phones the info icon is circular, and on changing resolution it becomes oval.

@danascape
Copy link
Copy Markdown
Member

This is not an issue with values, but the rendering of the navigation bar, which is a major blocker for releasing the library :/

Signed-off-by: Owm Dubey <owmdubey163@gmail.com>
@Roniscend
Copy link
Copy Markdown
Author

Roniscend commented Apr 21, 2026

I have added horizontal scrolling to the navigation row , which allows button to maintain their shape and size. Also I have tested this in multiple screens as well and it is working fine.

@Roniscend
Copy link
Copy Markdown
Author

@danascape can you re-review the pr please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Navbar info icon appears oval instead of circular

3 participants