frame compressor uses CompressTable#208
Open
matthewfollegot wants to merge 1 commit into
Open
Conversation
matthewfollegot
commented
Mar 9, 2026
Comment on lines
+753
to
+758
| pub fn reposition(&mut self, offset: u32) { | ||
| match self { | ||
| CompressTable::Large(t) => t.reposition(offset), | ||
| CompressTable::Small(_) => panic!("reposition is not supported on small tables"), | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
@PSeitz I'm thinking we should just remove this as it seems to be dead code for HashTable4K anyway https://github.com/matthewfollegot/lz4_flex/blob/c68d8896f9ea62683548edb6d50db57749043e1a/src/block/hashtable.rs#L119C12-L119C22. Wdyt?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #207. The frame compressor can utilize the
CompressTablewhich will start out withHashTable4KU16and will grow toHashTable4Kwhen needed, optimizing for small blocksizes.