Add configurable Claude and OpenAI review ensemble - #42
Draft
pweiskircher wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
claude,openai, orclaude,openaiclaude.json,openai.json, andsynthesized.jsondocuments as private workflow artifactsCompatibility
Claude remains the default. A caller that only supplies
claude-api-keyfollows the existing Claude path without installing Codex, requiring an OpenAI key, or invoking synthesis. Single-reviewer JSON is passed through unchanged before the existing filtering/enrichment stage.The OpenAI key is only required when OpenAI is selected. If multiple selected reviewers or the synthesizer fail, the action fails instead of posting a partial public review.
Security boundaries
CODEX_API_KEY, an ephemeral session, ignored user/repository rules, and a read-only sandboxTesting
pytest claudecode -q— 234 passedbun test comment-pr-findings.bun.test.js— 26 passedbash scripts/test-determine-claudecode-enablement.sh— 28 passedbash scripts/test-detect-trigger-type.sh— 16 passedgit diff --checkaction.ymlYAML parsePYTHONPATHregression; no other accepted findingsRollout note
No OpenAI secret is needed to merge this. The default remains Claude-only. Enabling OpenAI later is an explicit caller configuration and secret-management decision.