docs: correct stale directory paths in the php and website READMEs - #6239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two READMEs point at directories that no longer exist, so following either one fails immediately. Both are leftovers from moves that didn't update the surrounding prose.
prqlc/bindings/php/README.mdsaid to spawn the nix shell fromprql-php/; the binding lives atprqlc/bindings/php/.web/website/README.mdsaid to serve withcd website && hugo server. There's nowebsite/at the repo root — it'sweb/website/— and the repo already has a task for this, so the README now points attask web:run-websiterather than a path that can go stale again.No changelog entry, matching #6234 and other docs-only fixes. No test either — these are prose corrections; the verification is that the paths they now name exist and the task resolves.
Verification
Current state at
e0540ff:task web:run-websiteresolves through the rootTaskfile.yaml'sweb:include (taskfile: ./web,dir: ./web) toweb/Taskfile.yaml, whoserun-websitetask setsdir: websiteand runshugo server --bind 0.0.0.0— the same command the README described, from the directory that actually holdsconfig.yaml.prettier --checkpasses on both files.