Skip to content

updated code #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Surya-SDE16 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

updated code #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions src/arithmetic/arithmetic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ def add_numbers(a: int, b: int) -> int:
Returns:
Sum of a and b.
"""
raise NotImplementedError
return a + b
# raise NotImplementedError


def factorial(n: int) -> int:
Expand All @@ -28,7 +29,16 @@ def factorial(n: int) -> int:
Raises:
ValueError: if n is negative
"""
raise NotImplementedError
if n < 0:
raise ValueError
else:
if n == 0:
return 1
else:
fact = 1
for i in range(1, n + 1):
fact = fact * i
return fact


def is_prime(n: int) -> bool:
Expand All @@ -43,4 +53,10 @@ def is_prime(n: int) -> bool:
Returns:
True if n is prime; otherwise False.
"""
raise NotImplementedError
if n <= 1:
return False
else:
for i in range(2, n):
if n % i == 0:
return False
return True