Conversation
kad-marchal
approved these changes
Sep 11, 2026
kad-korpem
approved these changes
Sep 11, 2026
DvBree
merged commit Sep 18, 2026
427c0ef
into
PDOK-18835/vervanging-trex-v2-vertegeling
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix: there was undesireable behaviour when a geometry disappears after snapping (e.g., because it degenerates to points and lines). In this PR we replicate the behaviour from the current master version of
texelin thevervanging-trexfeature branch.Example; if
gis such a geometry, then the current feature branch behaviour (incorrect) is roughly to setnewGeometries[zoomLevel] = nil. The fixed behaviour is to leavenewGeometries[zoomLevel]to be unset.Aside from undesirable behaviour, this did cause the program to crash when using BBox for tile detection, since it would try to encode a nil geometry. This is a side effect of the fact that BBox does not discount degenerate parts of the polygon. Whether this is desirable is another issue.
Type of change
Checklist: