fix(download): 移除数据包的快速下载功能#3241
Conversation
审阅者指南(在小型 PR 上默认折叠)审阅者指南在现有对整合包(modpack)的限制基础上,禁用数据包(datapack)条目的快速下载功能,并移除未使用的数据包快速下载目标映射,这样快速下载工作流将不再处理数据包。 数据包变更后快速下载按钮可见性的流程图flowchart TD
A[PageComp.Load_OnFinish] --> B[Determine PageType]
B --> C{PageType}
C --> D[showQuickDownload = false]
C --> E[showQuickDownload = true]
C -->|ModPack| D
C -->|DataPack| D
C -->|Other types| E
移除数据包后快速下载目标解析的流程图flowchart TD
A[_StartQuickDownload] --> B[Resolve target subfolder by CompType]
B --> C{CompType}
C -->|ResourcePack| D[resourcepacks\\]
C -->|Shader| E[shaderpacks\\]
C -->|World| F[saves\\]
C -->|DataPack| G[" "]
style G fill:#fdd,stroke:#f66,stroke-width:1px
%% Note: DataPack case is now unreachable because quick download is disabled for DataPack
文件级变更
使用技巧与命令与 Sourcery 交互
自定义你的体验访问你的 控制面板 以:
获取帮助Original review guide in EnglishReviewer's guide (collapsed on small PRs)Reviewer's GuideDisables quick download for datapack entries alongside existing modpack restriction and removes the unused datapack quick-download target mapping so datapacks are no longer handled by the quick download workflow. Flow diagram for quick download button visibility after datapack changeflowchart TD
A[PageComp.Load_OnFinish] --> B[Determine PageType]
B --> C{PageType}
C --> D[showQuickDownload = false]
C --> E[showQuickDownload = true]
C -->|ModPack| D
C -->|DataPack| D
C -->|Other types| E
Flow diagram for quick download target resolution after datapack removalflowchart TD
A[_StartQuickDownload] --> B[Resolve target subfolder by CompType]
B --> C{CompType}
C -->|ResourcePack| D[resourcepacks\\]
C -->|Shader| E[shaderpacks\\]
C -->|World| F[saves\\]
C -->|DataPack| G[" "]
style G fill:#fdd,stroke:#f66,stroke-width:1px
%% Note: DataPack case is now unreachable because quick download is disabled for DataPack
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
嘿,我已经审查了你的更改,一切看起来都很棒!
帮我变得更有用!请在每条评论上点 👍 或 👎,我会根据你的反馈来改进之后的审查。
Original comment in English
Hey - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ff61ff14c1
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
由于数据包一般需要放置到存档的
datapacks文件夹内,因此快速下载功能需要选择存档,会增加耦合性由 Sourcery 提供的摘要
禁用数据包的快速下载支持,以减少与特定存档目录的耦合。
错误修复:
Original summary in English
Summary by Sourcery
Disable quick download support for datapacks to reduce coupling with specific save directories.
Bug Fixes: