chore: 移除 HMCL 图标#3235
Merged
Merged
Conversation
Contributor
审阅者指南(在小型 PR 上折叠)审阅者指南此 PR 移除了剩余的 HMCL 标题 Logo 相关引用,从而使 HMCL 图标不再在任何 UI Logo 选择逻辑中被显示或控制。 在没有 HMCL 图标时,UiLogoType 控制 Logo 可见性的流程图flowchart TD
A[UiLogoType value] --> B{Logo mode}
B -->|0: NoLogo| C[Hide ShapeHMCLTitleLogo
Hide LabTitleLogo
Hide ImageTitleLogo
Hide CELogo]
B -->|1: CEOnly| D[Hide ShapeHMCLTitleLogo
Hide LabTitleLogo
Hide ImageTitleLogo
Show CELogo]
B -->|2: TextLogo| E[Hide ShapeHMCLTitleLogo
Show LabTitleLogo
Hide ImageTitleLogo
Show CELogo]
B -->|3: ImageLogo| F[Hide ShapeHMCLTitleLogo
Hide LabTitleLogo
Show ImageTitleLogo
Show CELogo]
B -->|4: HelpMode| G[Hide ShapeHMCLTitleLogo
Hide LabTitleLogo
Hide ImageTitleLogo
Show BtnTitleHelp]
%% Note: ImageHMCLTitleLogo is no longer referenced in any branch
文件级变更
提示与命令与 Sourcery 交互
自定义使用体验访问你的 控制面板 以:
获取帮助Original review guide in EnglishReviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR removes remaining references to the HMCL title logo so that the HMCL icon is no longer shown or controlled anywhere in the UI logo selection logic. Flow diagram for UiLogoType logo visibility without HMCL iconflowchart TD
A[UiLogoType value] --> B{Logo mode}
B -->|0: NoLogo| C[Hide ShapeHMCLTitleLogo
Hide LabTitleLogo
Hide ImageTitleLogo
Hide CELogo]
B -->|1: CEOnly| D[Hide ShapeHMCLTitleLogo
Hide LabTitleLogo
Hide ImageTitleLogo
Show CELogo]
B -->|2: TextLogo| E[Hide ShapeHMCLTitleLogo
Show LabTitleLogo
Hide ImageTitleLogo
Show CELogo]
B -->|3: ImageLogo| F[Hide ShapeHMCLTitleLogo
Hide LabTitleLogo
Show ImageTitleLogo
Show CELogo]
B -->|4: HelpMode| G[Hide ShapeHMCLTitleLogo
Hide LabTitleLogo
Hide ImageTitleLogo
Show BtnTitleHelp]
%% Note: ImageHMCLTitleLogo is no longer referenced in any branch
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - 我给了一些高层面的反馈:
- 由于现在已经没有任何地方控制
ImageHMCLTitleLogo的可见性了,建议从FormMain.xaml和其代码隐藏中移除该控件以及所有相关的绑定/事件处理器,以避免留下无用的 UI 元素。 - 你现在总是从
UiLogoType中的可见性矩阵里省略ImageHMCLTitleLogo;如果 HMCL 已被完全弃用,那么移除所有剩余的 HMCL 特定分支或常量,可能会让 logo 类型逻辑更加清晰简洁。
给 AI 代理的提示
Please address the comments from this code review:
## Overall Comments
- Since `ImageHMCLTitleLogo` visibility is no longer controlled anywhere, consider removing the control and any related bindings/event handlers from `FormMain.xaml` and code-behind to avoid leaving dead UI elements.
- You now always omit `ImageHMCLTitleLogo` from the visibility matrix in `UiLogoType`; if HMCL is fully dropped, it may be clearer to remove any remaining HMCL-specific branches or constants to simplify the logo-type logic.帮我变得更有用!请在每条评论上点击 👍 或 👎,我会根据你的反馈改进后续评审。
Original comment in English
Hey - I've left some high level feedback:
- Since
ImageHMCLTitleLogovisibility is no longer controlled anywhere, consider removing the control and any related bindings/event handlers fromFormMain.xamland code-behind to avoid leaving dead UI elements. - You now always omit
ImageHMCLTitleLogofrom the visibility matrix inUiLogoType; if HMCL is fully dropped, it may be clearer to remove any remaining HMCL-specific branches or constants to simplify the logo-type logic.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since `ImageHMCLTitleLogo` visibility is no longer controlled anywhere, consider removing the control and any related bindings/event handlers from `FormMain.xaml` and code-behind to avoid leaving dead UI elements.
- You now always omit `ImageHMCLTitleLogo` from the visibility matrix in `UiLogoType`; if HMCL is fully dropped, it may be clearer to remove any remaining HMCL-specific branches or constants to simplify the logo-type logic.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
lhx077
approved these changes
Jun 21, 2026
Hill23333
approved these changes
Jun 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
从主窗口 UI 设置逻辑中移除剩余的 HMCL 标题徽标相关引用,使其不再显示,也不再受徽标类型设置的控制。
Original summary in English
Summary by Sourcery
Remove remaining references to the HMCL title logo from the main window UI setup logic so it is no longer shown or controlled by logo type settings.