Skip to content

chore: 移除 HMCL 图标#3235

Merged
lhx077 merged 1 commit into
devfrom
chore/remove-HMCL-LOGO
Jun 21, 2026
Merged

chore: 移除 HMCL 图标#3235
lhx077 merged 1 commit into
devfrom
chore/remove-HMCL-LOGO

Conversation

@LuLu-ling

@LuLu-ling LuLu-ling commented Jun 21, 2026

Copy link
Copy Markdown
Member

Summary by Sourcery

从主窗口 UI 设置逻辑中移除剩余的 HMCL 标题徽标相关引用,使其不再显示,也不再受徽标类型设置的控制。

Original summary in English

Summary by Sourcery

Remove remaining references to the HMCL title logo from the main window UI setup logic so it is no longer shown or controlled by logo type settings.

@LuLu-ling LuLu-ling requested a review from a team June 21, 2026 11:27
@pcl-ce-automation pcl-ce-automation Bot added 🛠️ 等待审查 Pull Request 已完善,等待维护者或负责人进行代码审查 size: XS PR 大小评估:微型 labels Jun 21, 2026
@sourcery-ai

sourcery-ai Bot commented Jun 21, 2026

Copy link
Copy Markdown
Contributor
审阅者指南(在小型 PR 上折叠)

审阅者指南

此 PR 移除了剩余的 HMCL 标题 Logo 相关引用,从而使 HMCL 图标不再在任何 UI Logo 选择逻辑中被显示或控制。

在没有 HMCL 图标时,UiLogoType 控制 Logo 可见性的流程图

flowchart TD
    A[UiLogoType value] --> B{Logo mode}

    B -->|0: NoLogo| C[Hide ShapeHMCLTitleLogo
Hide LabTitleLogo
Hide ImageTitleLogo
Hide CELogo]

    B -->|1: CEOnly| D[Hide ShapeHMCLTitleLogo
Hide LabTitleLogo
Hide ImageTitleLogo
Show CELogo]

    B -->|2: TextLogo| E[Hide ShapeHMCLTitleLogo
Show LabTitleLogo
Hide ImageTitleLogo
Show CELogo]

    B -->|3: ImageLogo| F[Hide ShapeHMCLTitleLogo
Hide LabTitleLogo
Show ImageTitleLogo
Show CELogo]

    B -->|4: HelpMode| G[Hide ShapeHMCLTitleLogo
Hide LabTitleLogo
Hide ImageTitleLogo
Show BtnTitleHelp]

    %% Note: ImageHMCLTitleLogo is no longer referenced in any branch
Loading

文件级变更

变更 详情 文件
从 UI Logo 类型选择逻辑中移除 HMCL 特定的标题 Logo 控制。
  • 在所有 UiLogoType 分支中删除对 ImageHMCLTitleLogo.Visibility 的赋值,以便不再在任何 Logo 模式下切换 HMCL 图像
  • 在 UiLogoType 中仅依赖通用标题 Logo 和 CE Logo 元素进行可见性管理
Plain Craft Launcher 2/Modules/Base/ModSetup.cs
清理主窗口 XAML 布局中的 HMCL 标题 Logo UI 元素定义。
  • 从主窗口 XAML 中移除 ImageHMCLTitleLogo 控件(或相关 HMCL 图标 UI 资源),使其不再属于可视树的一部分
Plain Craft Launcher 2/FormMain.xaml

提示与命令

与 Sourcery 交互

  • 触发新的审阅: 在 pull request 上评论 @sourcery-ai review
  • 继续讨论: 直接回复 Sourcery 的审阅评论。
  • 从审阅评论生成 GitHub issue: 回复 Sourcery 的审阅评论,要求其从该评论创建一个 issue。你也可以直接回复审阅评论 @sourcery-ai issue 来从该评论创建 issue。
  • 生成 pull request 标题: 在 pull request 标题中的任意位置写上 @sourcery-ai,即可在任何时间生成标题。你也可以在 pull request 中评论 @sourcery-ai title 来(重新)生成标题。
  • 生成 pull request 摘要: 在 pull request 正文中的任意位置写上 @sourcery-ai summary,即可在你想要的位置生成 PR 摘要。你也可以在 pull request 中评论 @sourcery-ai summary 来(重新)生成摘要。
  • 生成审阅者指南: 在 pull request 中评论 @sourcery-ai guide,即可在任何时间(重新)生成审阅者指南。
  • 解决所有 Sourcery 评论: 在 pull request 中评论 @sourcery-ai resolve,即可将所有 Sourcery 评论标记为已解决。当你已经处理完所有评论且不想再看到它们时非常有用。
  • 忽略所有 Sourcery 审阅: 在 pull request 中评论 @sourcery-ai dismiss,即可忽略所有现有的 Sourcery 审阅。当你想从一次全新的审阅开始时尤其有用——记得再评论 @sourcery-ai review 来触发新的审阅!

自定义使用体验

访问你的 控制面板 以:

  • 启用或禁用审阅功能,例如 Sourcery 生成的 pull request 摘要、审阅者指南等。
  • 更改审阅语言。
  • 添加、移除或编辑自定义审阅指令。
  • 调整其他审阅设置。

获取帮助

Original review guide in English
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR removes remaining references to the HMCL title logo so that the HMCL icon is no longer shown or controlled anywhere in the UI logo selection logic.

Flow diagram for UiLogoType logo visibility without HMCL icon

flowchart TD
    A[UiLogoType value] --> B{Logo mode}

    B -->|0: NoLogo| C[Hide ShapeHMCLTitleLogo
Hide LabTitleLogo
Hide ImageTitleLogo
Hide CELogo]

    B -->|1: CEOnly| D[Hide ShapeHMCLTitleLogo
Hide LabTitleLogo
Hide ImageTitleLogo
Show CELogo]

    B -->|2: TextLogo| E[Hide ShapeHMCLTitleLogo
Show LabTitleLogo
Hide ImageTitleLogo
Show CELogo]

    B -->|3: ImageLogo| F[Hide ShapeHMCLTitleLogo
Hide LabTitleLogo
Show ImageTitleLogo
Show CELogo]

    B -->|4: HelpMode| G[Hide ShapeHMCLTitleLogo
Hide LabTitleLogo
Hide ImageTitleLogo
Show BtnTitleHelp]

    %% Note: ImageHMCLTitleLogo is no longer referenced in any branch
Loading

File-Level Changes

Change Details Files
Remove HMCL-specific title logo control from the UI logo type selection logic.
  • Delete all assignments to ImageHMCLTitleLogo.Visibility across UiLogoType switch branches so the HMCL image is no longer toggled for any logo mode
  • Rely only on the generic title logo and CE logo elements for visibility management in UiLogoType
Plain Craft Launcher 2/Modules/Base/ModSetup.cs
Clean up HMCL title logo UI element definition from the main window XAML layout.
  • Remove the ImageHMCLTitleLogo control (or related HMCL-icon UI resources) from the main window XAML so it is no longer part of the visual tree
Plain Craft Launcher 2/FormMain.xaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - 我给了一些高层面的反馈:

  • 由于现在已经没有任何地方控制 ImageHMCLTitleLogo 的可见性了,建议从 FormMain.xaml 和其代码隐藏中移除该控件以及所有相关的绑定/事件处理器,以避免留下无用的 UI 元素。
  • 你现在总是从 UiLogoType 中的可见性矩阵里省略 ImageHMCLTitleLogo;如果 HMCL 已被完全弃用,那么移除所有剩余的 HMCL 特定分支或常量,可能会让 logo 类型逻辑更加清晰简洁。
给 AI 代理的提示
Please address the comments from this code review:

## Overall Comments
- Since `ImageHMCLTitleLogo` visibility is no longer controlled anywhere, consider removing the control and any related bindings/event handlers from `FormMain.xaml` and code-behind to avoid leaving dead UI elements.
- You now always omit `ImageHMCLTitleLogo` from the visibility matrix in `UiLogoType`; if HMCL is fully dropped, it may be clearer to remove any remaining HMCL-specific branches or constants to simplify the logo-type logic.

Sourcery 对开源项目是免费的——如果你喜欢我们的评审,请考虑分享它们 ✨
帮我变得更有用!请在每条评论上点击 👍 或 👎,我会根据你的反馈改进后续评审。
Original comment in English

Hey - I've left some high level feedback:

  • Since ImageHMCLTitleLogo visibility is no longer controlled anywhere, consider removing the control and any related bindings/event handlers from FormMain.xaml and code-behind to avoid leaving dead UI elements.
  • You now always omit ImageHMCLTitleLogo from the visibility matrix in UiLogoType; if HMCL is fully dropped, it may be clearer to remove any remaining HMCL-specific branches or constants to simplify the logo-type logic.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Since `ImageHMCLTitleLogo` visibility is no longer controlled anywhere, consider removing the control and any related bindings/event handlers from `FormMain.xaml` and code-behind to avoid leaving dead UI elements.
- You now always omit `ImageHMCLTitleLogo` from the visibility matrix in `UiLogoType`; if HMCL is fully dropped, it may be clearer to remove any remaining HMCL-specific branches or constants to simplify the logo-type logic.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@pcl-ce-automation pcl-ce-automation Bot added 🕑 等待合并 已处理完毕,正在等待代码合并入主分支 and removed 🛠️ 等待审查 Pull Request 已完善,等待维护者或负责人进行代码审查 labels Jun 21, 2026
@lhx077 lhx077 merged commit 305cb97 into dev Jun 21, 2026
3 checks passed
@pcl-ce-automation pcl-ce-automation Bot added 👌 完成 相关问题已修复或功能已实现,计划在下次版本更新时正式上线 and removed 🕑 等待合并 已处理完毕,正在等待代码合并入主分支 labels Jun 21, 2026
@lhx077 lhx077 deleted the chore/remove-HMCL-LOGO branch June 21, 2026 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: XS PR 大小评估:微型 👌 完成 相关问题已修复或功能已实现,计划在下次版本更新时正式上线

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants