fix(download): 修复社区资源搜索页返回后收藏按钮 hover 失效 [Composer]#3232
Merged
Conversation
RefreshFavoriteStatus 误将 ShowFavoriteBtn 设为是否已收藏, PageComp 重新可见时未收藏项的按钮被 Collapsed,导致 hover 无法展示。 Close PCL-Community#3230 Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's Guide调整 File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your Experience前往你的 dashboard 可以:
Getting HelpOriginal review guide in EnglishReviewer's guide (collapsed on small PRs)Reviewer's GuideAdjusts favorite status refresh logic in MyCompItem to only update the heart icon without toggling the visibility flag, ensuring hover-based favorite button display remains consistent after returning from detail pages. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
嗨——我已经审查了你的改动,一切看起来都很棒!
帮我变得更有用!请在每条评论上点击 👍 或 👎,我会根据这些反馈不断改进对你的代码审查。
Original comment in English
Hey - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Chiloven945
approved these changes
Jun 21, 2026
whitecat346
approved these changes
Jun 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MyCompItem.RefreshFavoriteStatus仅更新心形图标(实心/空心),不再修改ShowFavoriteBtn问题描述
社区资源搜索列表页(Mod、整合包、资源包、光影、数据包、地图等,均基于
PageComp+MyCompItem)中,列表项 hover 时应显示右侧收藏按钮。从任意列表项进入详情页再返回后,当前视窗内已渲染的列表项 hover 不再显示收藏按钮;向下滚动后,新进入视窗(懒加载)的列表项 hover 仍正常。
根因
PageComp_IsVisibleChanged触发RefreshAllFavoriteStatus()RefreshFavoriteStatus()将ShowFavoriteBtn = isFavouritePanButtons被设为Collapsed,hover 动画条件ShowFavoriteBtn == true不再满足MyVirtualizingElement懒加载,未经过此次刷新,故表现不一致影响范围
所有使用
PageComp的社区资源下载搜索页:不影响详情页顶部卡片(该处显式
ShowFavoriteBtn = false)。Test plan
Close #3230
Made with Cursor
Summary by Sourcery
Bug Fixes:
Original summary in English
Summary by Sourcery
Bug Fixes: