Skip to content

Repository navigation

Fix the date-dependent EventFilter tests and the paginated request open handle #1750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrisj-er wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix the date-dependent EventFilter tests and the paginated request open handle #1750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/EventFilter/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ describe('EventFilter', () => {
});

test('names the dates trigger state while the date range is modified', () => {
store.data.eventFilter.filter.date_range = { lower: '2026-09-01T00:00:00.000Z', upper: null };
store.data.eventFilter.filter.date_range = { lower: '2020-01-01T00:00:00.000Z', upper: null };

renderEventFilter();

Expand Down Expand Up @@ -347,7 +347,7 @@ describe('EventFilter', () => {
});

test('offers to reset while the date range is modified', () => {
store.data.eventFilter.filter.date_range = { lower: '2026-09-01T00:00:00.000Z', upper: null };
store.data.eventFilter.filter.date_range = { lower: '2020-01-01T00:00:00.000Z', upper: null };

renderEventFilter();

Expand Down
9 changes: 4 additions & 5 deletions src/utils/parallelPaginatedRequest.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,11 +82,10 @@ describe('parallelPaginatedRequest', () => {
});

test('throws error if first page can not be resolved', async () => {
try {
await parallelPaginatedRequest(`${EVENTS_API_URL}/notAPage?`);
} catch (e){
expect(e.message).toBe('Failed to fetch the first page. Aborting.');
}
server.use(http.get(`${EVENTS_API_URL}/notAPage`, () => new HttpResponse(null, { status: 500 })));

await expect(parallelPaginatedRequest(`${EVENTS_API_URL}/notAPage?`))
.rejects.toThrow('Failed to fetch the first page. Aborting.');
});

});
Loading