Merged
Conversation
- Upgraded Yarn from version 4.18.0 to 4.18.1 for improved performance and features. - Updated `dompurify` to version 3.4.16, `react-window` to version 2.3.3, `socket.io-client` to version 4.8.4, `dotenv` to version 18.0.4, and `vite` to version 8.3.1 for better functionality and security. - Updated `@oxc-project/types` and `@rolldown/binding-*` packages to version 0.151.0 and 1.2.11 respectively, ensuring compatibility with the latest changes. - Adjusted tests in `useFetchPatrolsFeed` to reflect the updated loading state handling.
- Eliminated the use of the community input feature flag across multiple components, including Footer, StatusSelect, and Actions, simplifying the logic for event state transitions. - Updated tests to reflect the removal of community input checks, ensuring they accurately represent the current functionality. - Cleaned up constants by removing the COMMUNITY_INPUT_ADMIN feature flag, streamlining the codebase.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Unrelated dependency, toolchain, and patrol-test changes should be separated from the feature-flag removal.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Removes the community_input_admin_enabled preview gate, making review-state actions universally available.
Changes:
- Ungates “Send to review” across event controls.
- Updates related tests and configuration fixtures.
- Also includes unrelated dependency, Yarn, and patrol-test changes.
| File | Description |
|---|---|
yarn.lock |
Updates dependency resolutions. |
src/SideBar/useFetchPatrolsFeed/index.test.js |
Changes asynchronous assertion timing. |
src/SideBar/EventsManager/EventsFeed/EventRow/index.test.js |
Removes obsolete preview configuration. |
src/SideBar/EventsManager/EventsFeed/EventRow/Actions/index.test.js |
Tests always-available review actions. |
src/SideBar/EventsManager/EventsFeed/EventRow/Actions/index.js |
Ungates the review action. |
src/SideBar/EventsManager/EventOverview/index.test.js |
Removes obsolete preview configuration. |
src/SideBar/EventsManager/EventOverview/Header/StatusSelect/index.test.js |
Removes flag-dependent setup and assertions. |
src/SideBar/EventsManager/EventOverview/Header/StatusSelect/index.js |
Always includes the review state. |
src/SideBar/EventsManager/EventOverview/Header/index.test.js |
Updates state-menu expectations. |
src/SideBar/EventsManager/EventOverview/Footer/index.test.js |
Tests the universal review save option. |
src/SideBar/EventsManager/EventOverview/Footer/index.js |
Ungates “Save and review.” |
src/SideBar/EventsManager/EventOverview/DetailsSection/index.test.js |
Removes obsolete preview configuration. |
src/EventFilter/index.test.js |
Removes obsolete preview configuration. |
src/EventFilter/FiltersPopover/index.test.js |
Removes obsolete preview configuration. |
src/EditableItem/Footer.js |
Ungates the legacy review action. |
src/ducks/system-config/index.test.js |
Replaces the removed flag in fixtures. |
src/constants/index.js |
Removes the preview-feature constant. |
package.json |
Upgrades dependencies and Yarn. |
.yarnrc.yml |
Updates the configured Yarn release. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Revised the README.md to streamline content, removing outdated sections and enhancing clarity for development setup and testing instructions. - Modified vite.config.mjs to utilize loadEnv for dynamic port configuration based on the environment, improving flexibility in development settings.
- Upgraded several packages including `@auth0/auth0-auth-js` to version 1.16.0, `@csstools/css-calc` to version 3.4.1, and `@rjsf/core` to version 6.11.0 for improved functionality and security. - Updated `brace-expansion` to version 5.0.12 and `content-type` to version 2.1.0 in the mock API for better compatibility. - Adjusted checksums and peer dependencies to reflect the latest versions across both lock files.
chrisj-er
approved these changes
Oct 1, 2026
# Conflicts: # src/ducks/system-config/index.test.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The
community_input_admin_enabledpreview feature is now on for every site, so this PR removes it from the web client. The review state and its options now always show, with no flag in front of them:StatusSelect): the options always include Send to review, in the order Active, Send to review, Resolve for an active event.newevent.EditableItem.Footer: the review dropdown item is no longer behind the flag.PREVIEW_FEATURES.COMMUNITY_INPUT_ADMINis removed fromsrc/constants. The flag's hook reads, the branches for the flag-off case, and the "remove this flag" comments are gone too.events_vector_tilesandpatrol_schemasare unchanged.Tests
Providerfor the flag read (Footer,StatusSelect) now render without one.ducks/system-configtests useevents_vector_tilesas their sample preview feature.Dependency updates
A separate commit (
c79b49c7c) includes routine patch-level upgrades:packageManager,.yarnrc.yml,.yarn/releases)dompurifyreact-windowsocket.io-clientdotenv(dev)vite(dev)In
yarn.lock, Vite's transitiverolldownand@rolldown/binding-*packages move from 1.2.9 to 1.2.11, and@oxc-project/typesfrom 0.150.0 to 0.151.0.The same commit also fixes a test in
useFetchPatrolsFeed. The check thatloadingPatrolsFeedgoes back tofalsenow runs inside thewaitForthat waits for the fetch actions. Before, it ran right after thewaitFor, before the hook's state update had been applied.Relevant link(s)
Notes
ERA-14071, notdevelop, so the diff only covers this ticket's changes.EditableItem.Footerisn't rendered anywhere. It was already unused before this PR, so this PR only removes the flag from it. Deleting the component is left for a separate change.🤖 Generated with Claude Code