Skip to content

fix: avoid NPE when SCAN_PARAMETERS intent extra is missing in onCreate #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
picheli20 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: avoid NPE when SCAN_PARAMETERS intent extra is missing in onCreate #58

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/main/kotlin/com/outsystems/plugins/barcode/view/OSBARCScannerActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,15 @@ class OSBARCScannerActivity : ComponentActivity() {

cameraExecutor = Executors.newSingleThreadExecutor()

val parameters = IntentCompat.getSerializableExtra(intent, SCAN_PARAMETERS, OSBARCScanParameters::class.java)!!
val parameters = IntentCompat.getSerializableExtra(intent, SCAN_PARAMETERS, OSBARCScanParameters::class.java)
if (parameters == null) {
// SCAN_PARAMETERS can be missing if the OS recreates this activity without the
// original intent extras (e.g. process death while backgrounded during a scan).
Log.e(LOG_TAG, "Missing $SCAN_PARAMETERS intent extra, finishing activity")
setResult(OSBARCError.INVALID_PARAMETERS_ERROR.code)
finish()
return
}

// possibly lock orientation, the screen is adaptive by default
if (parameters.scanOrientation == ORIENTATION_PORTRAIT) {
Expand Down