Skip to content

fix(permissions): confirm process termination commands - #30

Open
IgnoreMeBut wants to merge 1 commit into
Orkas-AI:mainfrom
IgnoreMeBut:fix/process-termination-approval
Open

fix(permissions): confirm process termination commands#30
IgnoreMeBut wants to merge 1 commit into
Orkas-AI:mainfrom
IgnoreMeBut:fix/process-termination-approval

Conversation

@IgnoreMeBut

Copy link
Copy Markdown
Contributor

Summary

  • classify POSIX kill, pkill, and killall, Windows taskkill, and PowerShell Stop-Process as destructive operations that require confirmation
  • keep non-terminating signal-zero probes, help/list forms, and PowerShell -WhatIf invocations prompt-free
  • verify an approval denial prevents later shell segments from executing

Source: Orkas commit 13eabd22bc8626067e14f61353d8a41e38d7551c, adapted onto the current OrkasOpen main branch. The internal permissions regression document was intentionally excluded, and existing sanitized Windows path fixtures were preserved.

Testing

  • node scripts/run-tests.mjs run test/main/model/core-agent/bash-risk.test.ts test/main/model/local-tools.test.ts — 2 files / 229 tests passed
  • node scripts/run-tests.mjs run test/main/model/core-agent/bash-permissions.test.ts test/main/features/permissions.test.ts test/main/ipc/permissions.test.ts test/renderer/bash-permission.test.ts — 4 files / 59 tests passed
  • npm run typecheck
  • git diff --check
  • selective OSS postcheck: no forbidden symbols/files, provider/API changes, orphan imports, UI/package violations, or TypeScript/renderer syntax failures

Local baseline limitations

The selective OSS postcheck still reports the pre-existing builtin-resource hash drift and full-sync coverage backlog; neither is changed by this three-file PR.

Classify POSIX kill commands, Windows taskkill, and PowerShell Stop-Process as destructive operations that require approval. Keep signal-zero probes, help/list commands, and WhatIf invocations non-destructive, with end-to-end denial coverage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant