fix(permissions): confirm process termination commands - #30
Open
IgnoreMeBut wants to merge 1 commit into
Open
Conversation
Classify POSIX kill commands, Windows taskkill, and PowerShell Stop-Process as destructive operations that require approval. Keep signal-zero probes, help/list commands, and WhatIf invocations non-destructive, with end-to-end denial coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kill,pkill, andkillall, Windowstaskkill, and PowerShellStop-Processas destructive operations that require confirmation-WhatIfinvocations prompt-freeSource: Orkas commit 13eabd22bc8626067e14f61353d8a41e38d7551c, adapted onto the current OrkasOpen main branch. The internal permissions regression document was intentionally excluded, and existing sanitized Windows path fixtures were preserved.
Testing
node scripts/run-tests.mjs run test/main/model/core-agent/bash-risk.test.ts test/main/model/local-tools.test.ts— 2 files / 229 tests passednode scripts/run-tests.mjs run test/main/model/core-agent/bash-permissions.test.ts test/main/features/permissions.test.ts test/main/ipc/permissions.test.ts test/renderer/bash-permission.test.ts— 4 files / 59 tests passednpm run typecheckgit diff --checkLocal baseline limitations
The selective OSS postcheck still reports the pre-existing builtin-resource hash drift and full-sync coverage backlog; neither is changed by this three-file PR.