python/iot3: add service_id to OTLP spans#533
Conversation
|
The description of the MR is not updated (in particular the link of the issue to be fixed) |
|
I had a problem to get python:3.11.17-slim-trixie: |
Hugues360
left a comment
There was a problem hiding this comment.
A little proposed modification for the type of service_id (Optional[str] should be I think better) but everything is ok otherwise, I approve
| *, | ||
| service_name: str, | ||
| endpoint: str, | ||
| service_id: str = None, |
There was a problem hiding this comment.
srvice-id should be Optional[str], no?
There was a problem hiding this comment.
srvice-id should be Optional[str], no?
Indeed. And this is also missing on others parameters too... I'll fix all of that, thanks!
MR description updated, thanks. |
MR description updated, thanks. |
8817c56 to
bb6c825
Compare
Reported-by: Hugues OUDEVILLE <hugues.oudeville@orange.com> Signed-off-by: Yann E. MORIN <yann.morin@orange.com>
Closes Orange-OpenSource#491 Signed-off-by: Yann E. MORIN <yann.morin@orange.com>
Signed-off-by: Yann E. MORIN <yann.morin@orange.com>
Signed-off-by: Yann E. MORIN <yann.morin@orange.com>
bb6c825 to
6a27c1e
Compare
Changes
Close #491
Test
How to test
Note: in the following, lines starting with
$are to be executed on yourmachine, as a non-root user;
lines starting with
(docker)$are to be executed in the Docker container;lines starting with
(docker)🐍 $are to be executed in the Docker container,in the python venv.
and the necessary packages:
$ docker container run \ --detach \ --name iot3 \ --rm \ -ti \ --network host \ -e http_proxy \ -e https_proxy \ -e no_proxy \ --user $(id -u):$(id -u) \ --mount type=bind,source=$(pwd),destination=$(pwd) \ --workdir $(pwd) \ python:3.11.14-slim-trixie \ /bin/bash -il $ docker container exec -u 0:0 iot3 apt update $ docker container exec -u 0:0 iot3 apt install -y git build-essential $ docker container attach iot3(docker)$ python3.11 -m venv /tmp/venv (docker)$ . /tmp/venv/bin/activate(docker)🐍 $ pip \ --disable-pip-version-check \ --no-cache-dir \ wheel \ -w /tmp/wheels \ python/iot3(docker)🐍 $ pip \ --disable-pip-version-check \ --no-cache-dir \ install \ --no-deps \ /tmp/wheels/*.whlExpected results